linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Nikolay Ledovskikh <nledovskikh@gmail.com>
Cc: linux-wireless@vger.kernel.org, lrodriguez@atheros.com,
	mickflemm@gmail.com, me@bobcopeland.com,
	Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [PATCH] ath5k: Use mips generic dma-mapping functions to avoid seqfault on AHB chips
Date: Tue, 15 Feb 2011 13:58:10 -0500	[thread overview]
Message-ID: <20110215185810.GH2557@tuxdriver.com> (raw)
In-Reply-To: <AANLkTi=6jVGZx0oQdMQmndCB9k_xPywfntsB1LS_4ekM@mail.gmail.com>

On Tue, Feb 15, 2011 at 09:49:24PM +0300, Nikolay Ledovskikh wrote:
> This patch fixes seqfault on ar2316 and other AHB based chips.
> (I don't know why it's not in archives)
> 
> Signed-off-by: Nikolay Ledovskikh <nledovskikh@gmail.com>
> ---
> diff --git a/drivers/net/wireless/ath/
> ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
> index 707cde1..35d5273 100644
> --- a/drivers/net/wireless/ath/ath5k/ahb.c
> +++ b/drivers/net/wireless/ath/ath5k/ahb.c
> @@ -34,7 +34,7 @@ static void ath5k_ahb_read_cachesize(struct ath_common
> *common, int *csz)
>  bool ath5k_ahb_eeprom_read(struct ath_common *common, u32 off, u16 *data)
>  {
>      struct ath5k_softc *sc = common->priv;
> -    struct platform_device *pdev = to_platform_device(sc->dev);
> +    struct platform_device *pdev =
> to_platform_device(wiphy_dev(sc->hw->wiphy));
>      struct ar231x_board_config *bcfg = pdev->dev.platform_data;
>      u16 *eeprom, *eeprom_end;
> 

Please use a mailer that doesn't do whitespace damage to patches --
I'll never live long enough to make-up for the time I've already
spent fixing-up broken patches...

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

       reply	other threads:[~2011-02-15 19:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AANLkTi=6jVGZx0oQdMQmndCB9k_xPywfntsB1LS_4ekM@mail.gmail.com>
2011-02-15 18:58 ` John W. Linville [this message]
2011-02-15 19:09 [PATCH] ath5k: Use mips generic dma-mapping functions to avoid seqfault on AHB chips Nikolay Ledovskikh
2011-02-15 19:40 ` Jiri Slaby
     [not found]   ` <AANLkTiks9rG2CzM2LabNerK3zgJ+R+weytQgvXxDbNe7@mail.gmail.com>
2011-02-15 20:42     ` Jiri Slaby
2011-02-15 20:57       ` Nikolay Ledovskikh
2011-02-15 21:03         ` Jiri Slaby
2011-02-15 21:18           ` Nikolay Ledovskikh
2011-02-15 21:39       ` Nikolay Ledovskikh
2011-02-15 22:16         ` Jiri Slaby
2011-02-15 22:18           ` Jiri Slaby
     [not found]             ` <20110216011203.GA5773@linux-mips.org>
2011-02-16 10:26               ` Nikolay Ledovskikh
2011-02-23 10:18                 ` Wojciech Dubowik
     [not found] <AANLkTinqN4MjWz4y5D195f9J8vob42GsG9u39xX-RuJf@mail.gmail.com>
2011-02-15 14:44 ` me
2011-02-15 14:49   ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110215185810.GH2557@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=jirislaby@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lrodriguez@atheros.com \
    --cc=me@bobcopeland.com \
    --cc=mickflemm@gmail.com \
    --cc=nledovskikh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).