From: "John W. Linville" <linville@tuxdriver.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-wireless@vger.kernel.org, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Luciano Coelho <luciano.coelho@nokia.com>,
Roger Quadros <roger.quadros@nokia.com>,
akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] wl12xx: fix sdio_test kconfig/build errors
Date: Mon, 21 Feb 2011 15:25:39 -0500 [thread overview]
Message-ID: <20110221202538.GK9650@tuxdriver.com> (raw)
In-Reply-To: <20110218172536.970b5b39.randy.dunlap@oracle.com>
Luca, I'm merging this one...
On Fri, Feb 18, 2011 at 05:25:36PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> The wl12xx sdio_test code uses wl12xx_get_platform_data, which is
> only present when WL12*_SDIO is enabled, so make WL12XX_SDIO_TEST
> depend on WL12XX_SDIO so that the needed interface will be present.
>
> sdio_test.c:(.devinit.text+0x13178): undefined reference to `wl12xx_get_platform_data'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Luciano Coelho <luciano.coelho@nokia.com>
> Cc: Roger Quadros <roger.quadros@nokia.com>
> ---
> drivers/net/wireless/wl12xx/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20110217.orig/drivers/net/wireless/wl12xx/Kconfig
> +++ linux-next-20110217/drivers/net/wireless/wl12xx/Kconfig
> @@ -54,7 +54,7 @@ config WL12XX_SDIO
>
> config WL12XX_SDIO_TEST
> tristate "TI wl12xx SDIO testing support"
> - depends on WL12XX && MMC
> + depends on WL12XX && MMC && WL12XX_SDIO
> default n
> ---help---
> This module adds support for the SDIO bus testing with the
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-02-21 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110217162650.092e77c3.sfr@canb.auug.org.au>
2011-02-19 1:25 ` [PATCH -next] wl12xx: fix sdio_test kconfig/build errors Randy Dunlap
2011-02-21 20:25 ` John W. Linville [this message]
2011-02-22 12:32 ` Coelho, Luciano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110221202538.GK9650@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@nokia.com \
--cc=randy.dunlap@oracle.com \
--cc=roger.quadros@nokia.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).