* [-next] ERROR: "usb_unanchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
@ 2011-02-17 12:56 Geert Uytterhoeven
2011-02-28 19:48 ` [PATCH] rtlwifi: usb parts should depend on CONFIG_USB John W. Linville
0 siblings, 1 reply; 10+ messages in thread
From: Geert Uytterhoeven @ 2011-02-17 12:56 UTC (permalink / raw)
To: George, Larry Finger, George, John W. Linville; +Cc: linux-wireless, linux-next
m68k/allmodconfig:
http://kisskb.ellerman.id.au/kisskb/buildresult/3914133/
ERROR: "usb_unanchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
ERROR: "usb_control_msg" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
ERROR: "usb_submit_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
ERROR: "usb_get_dev" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
ERROR: "usb_kill_anchored_urbs" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
ERROR: "usb_put_dev" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
ERROR: "usb_free_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
ERROR: "usb_anchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
ERROR: "usb_alloc_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
make: *** [sub-make] Error 2
The USB-part of rtlwifi should depend on CONFIG_USB.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] rtlwifi: usb parts should depend on CONFIG_USB 2011-02-17 12:56 [-next] ERROR: "usb_unanchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! Geert Uytterhoeven @ 2011-02-28 19:48 ` John W. Linville 2011-02-28 20:08 ` Johannes Berg 2011-02-28 21:01 ` [PATCH] " Larry Finger 0 siblings, 2 replies; 10+ messages in thread From: John W. Linville @ 2011-02-28 19:48 UTC (permalink / raw) To: linux-wireless Cc: Geert Uytterhoeven, Larry Finger, George, linux-next, John W. Linville ERROR: "usb_unanchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! ERROR: "usb_control_msg" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! ERROR: "usb_submit_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! ERROR: "usb_get_dev" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! ERROR: "usb_kill_anchored_urbs" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! ERROR: "usb_put_dev" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! ERROR: "usb_free_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! ERROR: "usb_anchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! ERROR: "usb_alloc_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! make[2]: *** [__modpost] Error 1 make[1]: *** [modules] Error 2 make: *** [sub-make] Error 2 The USB-part of rtlwifi should depend on CONFIG_USB. Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: John W. Linville <linville@tuxdriver.com> --- drivers/net/wireless/rtlwifi/Makefile | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/rtlwifi/Makefile b/drivers/net/wireless/rtlwifi/Makefile index 9192fd5..27355be 100644 --- a/drivers/net/wireless/rtlwifi/Makefile +++ b/drivers/net/wireless/rtlwifi/Makefile @@ -7,8 +7,7 @@ rtlwifi-objs := \ efuse.o \ ps.o \ rc.o \ - regd.o \ - usb.o + regd.o rtl8192c_common-objs += \ @@ -16,6 +15,10 @@ ifeq ($(CONFIG_PCI),y) rtlwifi-objs += pci.o endif +ifeq ($(CONFIG_USB),y) +rtlwifi-objs += usb.o +endif + obj-$(CONFIG_RTL8192C_COMMON) += rtl8192c/ obj-$(CONFIG_RTL8192CE) += rtl8192ce/ obj-$(CONFIG_RTL8192CU) += rtl8192cu/ -- 1.7.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] rtlwifi: usb parts should depend on CONFIG_USB 2011-02-28 19:48 ` [PATCH] rtlwifi: usb parts should depend on CONFIG_USB John W. Linville @ 2011-02-28 20:08 ` Johannes Berg 2011-02-28 20:13 ` John W. Linville 2011-02-28 21:01 ` [PATCH] " Larry Finger 1 sibling, 1 reply; 10+ messages in thread From: Johannes Berg @ 2011-02-28 20:08 UTC (permalink / raw) To: John W. Linville Cc: linux-wireless, Geert Uytterhoeven, Larry Finger, George, linux-next On Mon, 2011-02-28 at 14:48 -0500, John W. Linville wrote: > > +ifeq ($(CONFIG_USB),y) > +rtlwifi-objs += usb.o > +endif That reads weird, shouldn't rtlwifi-$(CONFIG_USB) += usb.o do? Or more likely actually use CONFIG_RTL8192CU? johannes ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rtlwifi: usb parts should depend on CONFIG_USB 2011-02-28 20:08 ` Johannes Berg @ 2011-02-28 20:13 ` John W. Linville 2011-02-28 21:16 ` Larry Finger 0 siblings, 1 reply; 10+ messages in thread From: John W. Linville @ 2011-02-28 20:13 UTC (permalink / raw) To: Johannes Berg Cc: linux-wireless, Geert Uytterhoeven, Larry Finger, George, linux-next On Mon, Feb 28, 2011 at 09:08:51PM +0100, Johannes Berg wrote: > On Mon, 2011-02-28 at 14:48 -0500, John W. Linville wrote: > > > > +ifeq ($(CONFIG_USB),y) > > +rtlwifi-objs += usb.o > > +endif > > That reads weird, shouldn't > > rtlwifi-$(CONFIG_USB) += usb.o > > do? Or more likely actually use CONFIG_RTL8192CU? Maybe...really just following what Larry already had there for pci...? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rtlwifi: usb parts should depend on CONFIG_USB 2011-02-28 20:13 ` John W. Linville @ 2011-02-28 21:16 ` Larry Finger 2011-02-28 21:21 ` Johannes Berg 0 siblings, 1 reply; 10+ messages in thread From: Larry Finger @ 2011-02-28 21:16 UTC (permalink / raw) To: John W. Linville Cc: Johannes Berg, linux-wireless, Geert Uytterhoeven, George, linux-next On 02/28/2011 02:13 PM, John W. Linville wrote: > On Mon, Feb 28, 2011 at 09:08:51PM +0100, Johannes Berg wrote: >> On Mon, 2011-02-28 at 14:48 -0500, John W. Linville wrote: >>> >>> +ifeq ($(CONFIG_USB),y) >>> +rtlwifi-objs += usb.o >>> +endif >> >> That reads weird, shouldn't >> >> rtlwifi-$(CONFIG_USB) += usb.o >> >> do? Or more likely actually use CONFIG_RTL8192CU? > > Maybe...really just following what Larry already had there for pci...? Yes, and that was wrong too. It could be either as Johannes wrote it, or ifneq ($(CONFIG_USB),) rtlwifi-objs += usb.o endif Yhe PCI entry will also fail if CONFIG_PCI=m. Larry ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rtlwifi: usb parts should depend on CONFIG_USB 2011-02-28 21:16 ` Larry Finger @ 2011-02-28 21:21 ` Johannes Berg 2011-02-28 21:27 ` Larry Finger 0 siblings, 1 reply; 10+ messages in thread From: Johannes Berg @ 2011-02-28 21:21 UTC (permalink / raw) To: Larry Finger Cc: John W. Linville, linux-wireless, Geert Uytterhoeven, George, linux-next On Mon, 2011-02-28 at 15:16 -0600, Larry Finger wrote: > On 02/28/2011 02:13 PM, John W. Linville wrote: > > On Mon, Feb 28, 2011 at 09:08:51PM +0100, Johannes Berg wrote: > >> On Mon, 2011-02-28 at 14:48 -0500, John W. Linville wrote: > >>> > >>> +ifeq ($(CONFIG_USB),y) > >>> +rtlwifi-objs += usb.o > >>> +endif > >> > >> That reads weird, shouldn't > >> > >> rtlwifi-$(CONFIG_USB) += usb.o > >> > >> do? Or more likely actually use CONFIG_RTL8192CU? > > > > Maybe...really just following what Larry already had there for pci...? > > Yes, and that was wrong too. > > It could be either as Johannes wrote it, or No, what I said won't work for m either, since you'd get rtlwifi-m += usb.o Though you can make that work by adding $(rtlwifi-m) manually to the list of objects later. johannes ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rtlwifi: usb parts should depend on CONFIG_USB 2011-02-28 21:21 ` Johannes Berg @ 2011-02-28 21:27 ` Larry Finger 2011-03-01 18:53 ` [PATCH v2] " John W. Linville 0 siblings, 1 reply; 10+ messages in thread From: Larry Finger @ 2011-02-28 21:27 UTC (permalink / raw) To: Johannes Berg Cc: John W. Linville, linux-wireless, Geert Uytterhoeven, George, linux-next On 02/28/2011 03:21 PM, Johannes Berg wrote: > On Mon, 2011-02-28 at 15:16 -0600, Larry Finger wrote: >> On 02/28/2011 02:13 PM, John W. Linville wrote: >>> On Mon, Feb 28, 2011 at 09:08:51PM +0100, Johannes Berg wrote: >>>> On Mon, 2011-02-28 at 14:48 -0500, John W. Linville wrote: >>>>> >>>>> +ifeq ($(CONFIG_USB),y) >>>>> +rtlwifi-objs += usb.o >>>>> +endif >>>> >>>> That reads weird, shouldn't >>>> >>>> rtlwifi-$(CONFIG_USB) += usb.o >>>> >>>> do? Or more likely actually use CONFIG_RTL8192CU? >>> >>> Maybe...really just following what Larry already had there for pci...? >> >> Yes, and that was wrong too. >> >> It could be either as Johannes wrote it, or > > No, what I said won't work for m either, since you'd get > > rtlwifi-m += usb.o > > Though you can make that work by adding $(rtlwifi-m) manually to the > list of objects later. I just tested it. As you say, your solution only works for y, not m. I think this is what is needed: -ifeq ($(CONFIG_PCI),y) +ifneq ($(CONFIG_PCI),) rtlwifi-objs += pci.o endif +ifneq ($(CONFIG_USB),) +rtlwifi-objs += usb.o +endif + At least it works wit PCI=y and USB=m. Larry ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] rtlwifi: usb parts should depend on CONFIG_USB 2011-02-28 21:27 ` Larry Finger @ 2011-03-01 18:53 ` John W. Linville 2011-03-01 19:54 ` Larry Finger 0 siblings, 1 reply; 10+ messages in thread From: John W. Linville @ 2011-03-01 18:53 UTC (permalink / raw) To: linux-wireless Cc: Larry Finger, Johannes Berg, Geert Uytterhoeven, George, linux-next, John W. Linville ERROR: "usb_unanchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! ERROR: "usb_control_msg" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! ERROR: "usb_submit_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! ERROR: "usb_get_dev" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! ERROR: "usb_kill_anchored_urbs" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! ERROR: "usb_put_dev" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! ERROR: "usb_free_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! ERROR: "usb_anchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! ERROR: "usb_alloc_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! make[2]: *** [__modpost] Error 1 make[1]: *** [modules] Error 2 make: *** [sub-make] Error 2 The USB-part of rtlwifi should depend on CONFIG_USB. Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: John W. Linville <linville@tuxdriver.com> --- drivers/net/wireless/rtlwifi/Makefile | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/rtlwifi/Makefile b/drivers/net/wireless/rtlwifi/Makefile index 9192fd5..ec9393f 100644 --- a/drivers/net/wireless/rtlwifi/Makefile +++ b/drivers/net/wireless/rtlwifi/Makefile @@ -7,15 +7,18 @@ rtlwifi-objs := \ efuse.o \ ps.o \ rc.o \ - regd.o \ - usb.o + regd.o rtl8192c_common-objs += \ -ifeq ($(CONFIG_PCI),y) +ifneq ($(CONFIG_PCI),) rtlwifi-objs += pci.o endif +ifneq ($(CONFIG_USB),) +rtlwifi-objs += usb.o +endif + obj-$(CONFIG_RTL8192C_COMMON) += rtl8192c/ obj-$(CONFIG_RTL8192CE) += rtl8192ce/ obj-$(CONFIG_RTL8192CU) += rtl8192cu/ -- 1.7.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2] rtlwifi: usb parts should depend on CONFIG_USB 2011-03-01 18:53 ` [PATCH v2] " John W. Linville @ 2011-03-01 19:54 ` Larry Finger 0 siblings, 0 replies; 10+ messages in thread From: Larry Finger @ 2011-03-01 19:54 UTC (permalink / raw) To: John W. Linville Cc: linux-wireless, Johannes Berg, Geert Uytterhoeven, George, linux-next On 03/01/2011 12:53 PM, John W. Linville wrote: > ERROR: "usb_unanchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! > ERROR: "usb_control_msg" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! > ERROR: "usb_submit_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! > ERROR: "usb_get_dev" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! > ERROR: "usb_kill_anchored_urbs" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! > ERROR: "usb_put_dev" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! > ERROR: "usb_free_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! > ERROR: "usb_anchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! > ERROR: "usb_alloc_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! > make[2]: *** [__modpost] Error 1 > make[1]: *** [modules] Error 2 > make: *** [sub-make] Error 2 > > The USB-part of rtlwifi should depend on CONFIG_USB. > > Reported-by: Geert Uytterhoeven<geert@linux-m68k.org> > Signed-off-by: John W. Linville<linville@tuxdriver.com> > --- > drivers/net/wireless/rtlwifi/Makefile | 9 ++++++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > John, If you change the commit message to indicate that you also fixed the case where CONFIG_PCI is m, then ACK. Larry > diff --git a/drivers/net/wireless/rtlwifi/Makefile b/drivers/net/wireless/rtlwifi/Makefile > index 9192fd5..ec9393f 100644 > --- a/drivers/net/wireless/rtlwifi/Makefile > +++ b/drivers/net/wireless/rtlwifi/Makefile > @@ -7,15 +7,18 @@ rtlwifi-objs := \ > efuse.o \ > ps.o \ > rc.o \ > - regd.o \ > - usb.o > + regd.o > > rtl8192c_common-objs += \ > > -ifeq ($(CONFIG_PCI),y) > +ifneq ($(CONFIG_PCI),) > rtlwifi-objs += pci.o > endif > > +ifneq ($(CONFIG_USB),) > +rtlwifi-objs += usb.o > +endif > + > obj-$(CONFIG_RTL8192C_COMMON) += rtl8192c/ > obj-$(CONFIG_RTL8192CE) += rtl8192ce/ > obj-$(CONFIG_RTL8192CU) += rtl8192cu/ ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rtlwifi: usb parts should depend on CONFIG_USB 2011-02-28 19:48 ` [PATCH] rtlwifi: usb parts should depend on CONFIG_USB John W. Linville 2011-02-28 20:08 ` Johannes Berg @ 2011-02-28 21:01 ` Larry Finger 1 sibling, 0 replies; 10+ messages in thread From: Larry Finger @ 2011-02-28 21:01 UTC (permalink / raw) To: John W. Linville; +Cc: linux-wireless, Geert Uytterhoeven, George, linux-next On 02/28/2011 01:48 PM, John W. Linville wrote: > ERROR: "usb_unanchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! > ERROR: "usb_control_msg" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! > ERROR: "usb_submit_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! > ERROR: "usb_get_dev" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! > ERROR: "usb_kill_anchored_urbs" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! > ERROR: "usb_put_dev" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! > ERROR: "usb_free_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! > ERROR: "usb_anchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! > ERROR: "usb_alloc_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! > make[2]: *** [__modpost] Error 1 > make[1]: *** [modules] Error 2 > make: *** [sub-make] Error 2 > > The USB-part of rtlwifi should depend on CONFIG_USB. > > Reported-by: Geert Uytterhoeven<geert@linux-m68k.org> > Signed-off-by: John W. Linville<linville@tuxdriver.com> > --- > drivers/net/wireless/rtlwifi/Makefile | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/rtlwifi/Makefile b/drivers/net/wireless/rtlwifi/Makefile > index 9192fd5..27355be 100644 > --- a/drivers/net/wireless/rtlwifi/Makefile > +++ b/drivers/net/wireless/rtlwifi/Makefile > @@ -7,8 +7,7 @@ rtlwifi-objs := \ > efuse.o \ > ps.o \ > rc.o \ > - regd.o \ > - usb.o > + regd.o > > rtl8192c_common-objs += \ > > @@ -16,6 +15,10 @@ ifeq ($(CONFIG_PCI),y) > rtlwifi-objs += pci.o > endif > > +ifeq ($(CONFIG_USB),y) > +rtlwifi-objs += usb.o > +endif > + > obj-$(CONFIG_RTL8192C_COMMON) += rtl8192c/ > obj-$(CONFIG_RTL8192CE) += rtl8192ce/ > obj-$(CONFIG_RTL8192CU) += rtl8192cu/ This fails on my system as CONFIG_USB=m, not y. Larry ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2011-03-01 19:55 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-02-17 12:56 [-next] ERROR: "usb_unanchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined! Geert Uytterhoeven 2011-02-28 19:48 ` [PATCH] rtlwifi: usb parts should depend on CONFIG_USB John W. Linville 2011-02-28 20:08 ` Johannes Berg 2011-02-28 20:13 ` John W. Linville 2011-02-28 21:16 ` Larry Finger 2011-02-28 21:21 ` Johannes Berg 2011-02-28 21:27 ` Larry Finger 2011-03-01 18:53 ` [PATCH v2] " John W. Linville 2011-03-01 19:54 ` Larry Finger 2011-02-28 21:01 ` [PATCH] " Larry Finger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).