Linux wireless drivers development
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
Cc: Daniel Halperin <dhalperi@cs.washington.edu>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ipw3945-devel@lists.sourceforge.net"
	<ipw3945-devel@lists.sourceforge.net>
Subject: Re: [ipw3945-devel] can't compile iwlwifi latest wireless-testing
Date: Sun, 6 Mar 2011 20:27:15 -0500	[thread overview]
Message-ID: <20110307012714.GA2465@tuxdriver.com> (raw)
In-Reply-To: <1299446809.5082.161.camel@wwguy-huron>

On Sun, Mar 06, 2011 at 01:26:49PM -0800, Guy, Wey-Yi wrote:
> Hi Daniel,
> 
> 
> On Fri, 2011-03-04 at 16:15 -0800, Daniel Halperin wrote:
> > drivers/net/wireless/iwlwifi/iwl-rx.c: In function
> > ‘iwl_rx_card_state_notif’:
> > drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: ‘TASK_INTERRUPTIBLE’
> > undeclared (first use in this function)
> > drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: (Each undeclared
> > identifier is reported only once
> > drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: for each function it
> > appears in.)
> > 
> > 
> > iwl-tx.c has an include for sched.h that isn't here and is probably
> > the problem.
> > 
> > 
> Stanislow last patch   
> commit 466a19a003f3b45a755bc85f967c21da947f9a00: iwlwifi: move rx
> handlers code to iwl-rx.c
> break the compile
> 
> John, please revert the patch

That seems a bit silly.  Does adding an include for sched.h to iwl-rx.c
fix the build issue?

I wonder why this builds fine for me?  What arch fails to build?

John
-- 
John W. Linville                Someday the world will need a hero, and you
linville@tuxdriver.com                  might be all we have.  Be ready.

  reply	other threads:[~2011-03-07  1:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AANLkTimaVjAsW4g8kAfi=vQaPCabkj-ZO9vZw_Lex7KY@mail.gmail.com>
2011-03-05  0:17 ` Fwd: can't compile iwlwifi latest wireless-testing Daniel Halperin
2011-03-06 21:26 ` [ipw3945-devel] " Guy, Wey-Yi
2011-03-07  1:27   ` John W. Linville [this message]
2011-03-07  1:30     ` Guy, Wey-Yi
2011-03-07  1:53     ` Daniel Halperin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110307012714.GA2465@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=dhalperi@cs.washington.edu \
    --cc=ipw3945-devel@lists.sourceforge.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=wey-yi.w.guy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox