From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Michael Buesch <mb@bu3sch.de>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Felix Fietkau <nbd@openwrt.org>,
Ben Greear <greearb@candelatech.com>
Subject: Re: WARN_ON in ieee80211_scan_completed_finish triggered
Date: Mon, 7 Mar 2011 15:22:42 +0100 [thread overview]
Message-ID: <20110307142241.GB9571@redhat.com> (raw)
In-Reply-To: <1299503693.6739.1.camel@jlt3.sipsolutions.net>
On Mon, Mar 07, 2011 at 02:14:53PM +0100, Johannes Berg wrote:
> on_oper_chan = ieee80211_cfg_on_oper_channel(local);
>
> WARN_ON(local->scanning & (SCAN_SW_SCANNING | SCAN_HW_SCANNING));
Not needed, just zeroed local->scanning.
> @@ -332,7 +321,6 @@ static void __ieee80211_scan_completed_f
> }
>
> ieee80211_recalc_idle(local);
> - mutex_unlock(&local->mtx);
>
> ieee80211_mlme_notify_scan_completed(local);
> ieee80211_ibss_notify_scan_completed(local);
I'm a bit worried about calling these with mutex.
Stanislaw
next prev parent reply other threads:[~2011-03-07 14:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-06 20:25 WARN_ON in ieee80211_scan_completed_finish triggered Michael Buesch
2011-03-07 9:51 ` Johannes Berg
2011-03-07 11:42 ` Michael Buesch
2011-03-07 11:44 ` Johannes Berg
2011-03-07 12:03 ` Johannes Berg
2011-03-07 13:14 ` Johannes Berg
2011-03-07 13:59 ` Michael Buesch
2011-03-07 14:22 ` Stanislaw Gruszka [this message]
2011-03-07 14:30 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110307142241.GB9571@redhat.com \
--to=sgruszka@redhat.com \
--cc=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox