From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>
Subject: Re: [PATCH 4/4] ath9k: improve reliability of beacon transmission and stuck beacon handling
Date: Thu, 10 Mar 2011 15:16:29 +0530 [thread overview]
Message-ID: <20110310094629.GE28100@vasanth-laptop> (raw)
In-Reply-To: <1299717303-42430-4-git-send-email-nbd@openwrt.org>
On Thu, Mar 10, 2011 at 06:05:03AM +0530, Felix Fietkau wrote:
> ath9k calls ath9k_hw_stoptxdma every time it sends a beacon, however there
> is not much point in doing that if the previous beacon and mcast traffic
> went out properly. On AR9380, calling that function too often can result
> in an increase of stuck beacons due to differences in the handling of the
> queue enable/disable functionality.
>
> With this patch, the queue will only be explicitly stopped if the previous
> data frames were not sent successfully. With the beacon code being the
> only remaining user of ath9k_hw_stoptxdma, this function can be simplified
> in order to remove the now pointless attempts at waiting for transmission
> completion, which would never happen at this point due to the different
> method of tx scheduling of the beacon queue.
Thanks. Can this patch be split into two, one which possibly fixes btsuck
(a stable fix) and the other one which is a cleanup?.
Vasanth
next prev parent reply other threads:[~2011-03-10 9:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 0:35 [PATCH 1/4] ath9k_hw: fix REG_SET_BIT and REG_CLR_BIT for multiple bits Felix Fietkau
2011-03-10 0:35 ` [PATCH 2/4] ath9k: fix stopping tx dma on reset Felix Fietkau
2011-03-10 0:35 ` [PATCH 3/4] ath9k: fix the .flush driver op implementation Felix Fietkau
2011-03-10 0:35 ` [PATCH 4/4] ath9k: improve reliability of beacon transmission and stuck beacon handling Felix Fietkau
2011-03-10 9:46 ` Vasanthakumar Thiagarajan [this message]
2011-03-10 13:04 ` Felix Fietkau
2011-03-10 13:15 ` Felix Fietkau
2011-03-10 9:25 ` [PATCH 3/4] ath9k: fix the .flush driver op implementation Vasanthakumar Thiagarajan
2011-03-10 13:03 ` Felix Fietkau
2011-03-10 8:58 ` [PATCH 2/4] ath9k: fix stopping tx dma on reset Vasanthakumar Thiagarajan
2011-03-10 9:32 ` Vasanthakumar Thiagarajan
2011-03-10 12:47 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310094629.GE28100@vasanth-laptop \
--to=vasanth@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).