[PATCH] ath9k: fix aggregation related interoperability issues

[PATCH] ath9k: fix aggregation related interoperability issues

[Felix Fietkau]

Some clients seems to keep track of their reorder window even after an
aggregation session has been disabled. This causes issues if there are
still retried but not completed frames pending for the TID.
To ensure that rx does not stall in such situations, set sendbar to 1
for any frame purged from the TID queue on teardown.

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---
 drivers/net/wireless/ath/ath9k/xmit.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
index f977f80..ef22096 100644
--- a/drivers/net/wireless/ath/ath9k/xmit.c
+++ b/drivers/net/wireless/ath/ath9k/xmit.c
@@ -166,7 +166,7 @@ static void ath_tx_flush_tid(struct ath_softc *sc, struct ath_atx_tid *tid)
 		fi = get_frame_info(bf->bf_mpdu);
 		if (fi->retries) {
 			ath_tx_update_baw(sc, tid, fi->seqno);
-			ath_tx_complete_buf(sc, bf, txq, &bf_head, &ts, 0, 0);
+			ath_tx_complete_buf(sc, bf, txq, &bf_head, &ts, 0, 1);
 		} else {
 			ath_tx_send_normal(sc, txq, NULL, &bf_head);
 		}
-- 
1.7.3.2

Re: [PATCH] ath9k: fix aggregation related interoperability issues

[Vasanthakumar Thiagarajan]

On Sat, Mar 12, 2011 at 05:41:28AM +0530, Felix Fietkau wrote:
> Some clients seems to keep track of their reorder window even after an
> aggregation session has been disabled. This causes issues if there are
> still retried but not completed frames pending for the TID.
> To ensure that rx does not stall in such situations, set sendbar to 1
> for any frame purged from the TID queue on teardown.

Once decided to to terminate the aggr session, sending a delba for that tid
seems to be the right thing.

Vasanth

Re: [PATCH] ath9k: fix aggregation related interoperability issues

[Felix Fietkau]

On 2011-03-12 7:26 AM, Vasanthakumar Thiagarajan wrote:
> On Sat, Mar 12, 2011 at 05:41:28AM +0530, Felix Fietkau wrote:
>> Some clients seems to keep track of their reorder window even after an
>> aggregation session has been disabled. This causes issues if there are
>> still retried but not completed frames pending for the TID.
>> To ensure that rx does not stall in such situations, set sendbar to 1
>> for any frame purged from the TID queue on teardown.
> 
> Once decided to to terminate the aggr session, sending a delba for that tid
> seems to be the right thing.
The session is terminated properly through a DELBA either way, my patch
only affects what happens to frames during the cleanup, as some clients
seem to have issues here. User reports confirm that this patch
significantly improves connection stability.

- Felix