From: Arnd Bergmann <arnd@arndb.de>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Arend van Spriel <arend@broadcom.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
rmk+kernel@arm.linux.org.uk, devel@linuxdriverproject.org,
gregkh@suse.de, linux-wireless@vger.kernel.org,
Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [PATCH 1/1] drivers: brcmaxi: provide amba axi functionality in separate module
Date: Wed, 30 Mar 2011 14:53:48 +0200 [thread overview]
Message-ID: <201103301453.48607.arnd@arndb.de> (raw)
In-Reply-To: <4D91B856.8040302@suse.cz>
On Tuesday 29 March 2011, Jiri Slaby wrote:
> On 03/29/2011 11:40 AM, Arend van Spriel wrote:
> > --- /dev/null
> > +++ b/drivers/brcmaxi/axi.c
> > @@ -0,0 +1,786 @@
> ...
> > +/* resetctrl */
> > +#define AIRC_RESET 1
> > +
> > +/* definition for specifying padding fields */
> > +#define _PADLINE(line) pad ## line
> > +#define _XSTR(line) _PADLINE(line)
> > +#define PAD _XSTR(__LINE__)
> > +
> > +/*
> > + * struct aidmp - device management plugin "wrapper" registers.
> > + */
> > +struct aidmp {
>
> This looks like it should be __packed__.
Why that? Adding the packed attribute would enforce byte access but
not change the layout of the structure, so I think that would make
it worse not better.
Arnd
next prev parent reply other threads:[~2011-03-30 12:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 9:40 [PATCH 0/1] new module for amba axi on-chip interconnect Arend van Spriel
2011-03-29 9:40 ` [PATCH 1/1] drivers: brcmaxi: provide amba axi functionality in separate module Arend van Spriel
2011-03-29 10:45 ` Jiri Slaby
2011-03-30 12:53 ` Arnd Bergmann [this message]
2011-03-31 13:48 ` Jiri Slaby
2011-03-31 13:51 ` Russell King
2011-03-31 14:09 ` Jiri Slaby
2011-03-31 14:14 ` Russell King
2011-03-31 16:10 ` Jiri Slaby
2011-04-01 9:14 ` Arnd Bergmann
2011-03-29 13:14 ` [PATCH 0/1] new module for amba axi on-chip interconnect Greg KH
2011-03-29 18:19 ` Russell King
2011-03-30 13:09 ` Arnd Bergmann
2011-03-30 17:40 ` Russell King - ARM Linux
2011-03-30 18:24 ` Arnd Bergmann
2011-03-30 19:08 ` Russell King - ARM Linux
2011-04-01 15:40 ` Arnd Bergmann
2011-03-29 18:30 ` Christoph Hellwig
2011-03-29 18:40 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103301453.48607.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=arend@broadcom.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).