From: Jarkko Nikula <jhnikula@gmail.com>
To: Kalle Valo <kvalo@adurom.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH 1/2] wl1251: Prepare for idle mode support
Date: Mon, 4 Apr 2011 09:49:47 +0300 [thread overview]
Message-ID: <20110404094947.5b178d78.jhnikula@gmail.com> (raw)
In-Reply-To: <87aag9srom.fsf@purkki.adurom.net>
On Fri, 01 Apr 2011 22:22:01 +0300
Kalle Valo <kvalo@adurom.com> wrote:
> > Then enum wl1251_cmd_ps_mod in cmd.h is renamed and moved to wl1251.h as it
> > is a state rather than chip level command.
>
> But now you are moving a firmware interface value outside cmd.h. I was
> thinking that you would touch wl1251_cmd_ps_mod at all, instead just
> create a new enum wl1251_station_mode which will be used as the driver
> state variable.
>
> That way it's clear which enum is for the firmware interface and which
> one is an internal variable.
>
I agree, I was blind to see that the wl1251_cmd_ps_mode indeed sends the
value to chip... I'll send an update where the enum wl1251_cmd_ps_mod is
kept intact.
--
Jarkko
next prev parent reply other threads:[~2011-04-04 6:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 13:04 [PATCH 1/2] wl1251: Prepare for idle mode support Jarkko Nikula
2011-03-31 13:04 ` [PATCH 2/2] wl1251: Add support for idle mode Jarkko Nikula
2011-04-01 19:30 ` Kalle Valo
2011-04-01 19:22 ` [PATCH 1/2] wl1251: Prepare for idle mode support Kalle Valo
2011-04-04 6:49 ` Jarkko Nikula [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-04-04 8:04 Jarkko Nikula
2011-04-04 18:15 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110404094947.5b178d78.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).