From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Thomas Pedersen <thomas@cozybit.com>
Cc: linux-wireless@vger.kernel.org, johannes@sipsolutions.net,
javier@cozybit.com, linville@tuxdriver.com
Subject: Re: [PATCH v7 01/10] nl80211: rename NL80211_MESH_SETUP_VENDOR_PATH_SEL_IE
Date: Wed, 6 Apr 2011 15:31:51 +0200 [thread overview]
Message-ID: <20110406133151.GB2197@redhat.com> (raw)
In-Reply-To: <1301966140-26080-2-git-send-email-thomas@cozybit.com>
On Mon, Apr 04, 2011 at 06:15:31PM -0700, Thomas Pedersen wrote:
> - /* first allocate the new vendor information element */
> + /* allocate information elements */
> new_ie = NULL;
> - old_ie = ifmsh->vendor_ie;
> + old_ie = ifmsh->ie;
>
> - ifmsh->vendor_ie_len = setup->vendor_ie_len;
> - if (setup->vendor_ie_len) {
> - new_ie = kmemdup(setup->vendor_ie, setup->vendor_ie_len,
> + ifmsh->ie_len = setup->ie_len;
> + if (setup->ie_len) {
> + new_ie = kmemdup(setup->ie, setup->ie_len,
> GFP_KERNEL);
> if (!new_ie)
> return -ENOMEM;
No idea if this is a problem, but in !new_ie case, after function
exit ifmsh->ie_len will not match ifmsh->ie .
Stanislaw
next prev parent reply other threads:[~2011-04-06 13:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 1:15 [PATCH v7 00/10] mesh security enhancements Thomas Pedersen
2011-04-05 1:15 ` [PATCH v7 01/10] nl80211: rename NL80211_MESH_SETUP_VENDOR_PATH_SEL_IE Thomas Pedersen
2011-04-06 13:31 ` Stanislaw Gruszka [this message]
2011-04-07 19:17 ` Thomas Pedersen
2011-04-05 1:15 ` [PATCH v7 02/10] nl80211: Add userspace authentication flag to mesh setup Thomas Pedersen
2011-04-05 1:15 ` [PATCH v7 03/10] mac80211: Support userspace mesh authentication Thomas Pedersen
2011-04-05 7:28 ` Johannes Berg
2011-04-05 1:15 ` [PATCH v7 04/10] mac80211: ignore peers if security is enabled for this mesh Thomas Pedersen
2011-04-05 1:15 ` [PATCH v7 05/10] nl80211: let userspace authenticate stations Thomas Pedersen
2011-04-05 1:15 ` [PATCH v7 06/10] mac80211: Let user space receive and send mesh auth/deauth frames Thomas Pedersen
2011-04-05 1:15 ` [PATCH v7 07/10] mac80211: ignore peer link requests from unauthenticated stations Thomas Pedersen
2011-04-05 1:15 ` [PATCH v7 08/10] mac80211: Perform PLINK_ACTION on new station Thomas Pedersen
2011-04-05 1:15 ` [PATCH v7 09/10] nl80211: New notification to discover mesh peer candidates Thomas Pedersen
2011-04-05 1:15 ` [PATCH v7 10/10] mac80211: send notification on new peer candidate for our secure mesh Thomas Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110406133151.GB2197@redhat.com \
--to=sgruszka@redhat.com \
--cc=javier@cozybit.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).