From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:51518 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756540Ab1DFPaZ (ORCPT ); Wed, 6 Apr 2011 11:30:25 -0400 Date: Wed, 6 Apr 2011 11:19:42 -0400 From: "John W. Linville" To: Stanislaw Gruszka Cc: Cong Wang , Johannes Berg , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Intel Linux Wireless , Wey-Yi Guy , Meenakshi Venkataraman , Larry Finger Subject: Re: [Patch] iwlwifi: remove obsoleted module alias and parameters Message-ID: <20110406151942.GE11941@tuxdriver.com> References: <1302083382-6715-1-git-send-email-amwang@redhat.com> <1302084582.3811.9.camel@jlt3.sipsolutions.net> <4D9C43A8.5060500@redhat.com> <20110406125728.GA2197@redhat.com> <20110406151429.GD11941@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <20110406151429.GD11941@tuxdriver.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Apr 06, 2011 at 11:14:29AM -0400, John W. Linville wrote: > On Wed, Apr 06, 2011 at 02:57:29PM +0200, Stanislaw Gruszka wrote: > > On Wed, Apr 06, 2011 at 06:42:48PM +0800, Cong Wang wrote: > > > 于 2011年04月06日 18:09, Johannes Berg 写道: > > > >On Wed, 2011-04-06 at 17:49 +0800, Amerigo Wang wrote: > > > >>As scheduled in Documentation/feature-removal-schedule.txt, > > > >>remove "*50", "disable_hw_scan" module parameters and MODULE_ALIAS("iwl4965"). > > > > > > > >Mostly fine, but for iwlegacy Stanislaw we want to keep hw scan (and it > > > >was actually made default now) > > > > Indeed, disable_hw_scan should be removed in iwlwifi but leaved in iwlegacy. > > > > > Ok, I will wait for Stanislaw's response and then send an updated patch. > > > > Have it now :-) > > Maybe the MODULE_ALIAS("iwl4965") should go to iwlegacy too? Nevermind, forgot the "Internal alias support has been present in module-init-tools" part... -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.