From: Antonio Ospite <ospite@studenti.unina.it>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-wireless@vger.kernel.org, openezx-devel@lists.openezx.org,
"John W . Linville" <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
Liam Girdwood <lrg@slimlogic.co.uk>,
linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
Guiming Zhuo <gmzhuo@gmail.com>
Subject: Re: [PATCH] rfkill: Regulator consumer driver for rfkill
Date: Wed, 6 Apr 2011 16:29:01 +0200 [thread overview]
Message-ID: <20110406162901.0efa11ad.ospite@studenti.unina.it> (raw)
In-Reply-To: <20110406141131.GC2810@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]
On Wed, 6 Apr 2011 23:11:33 +0900
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> On Wed, Apr 06, 2011 at 11:21:19AM +0200, Antonio Ospite wrote:
>
> > + tristate "Generic rfkill regulator driver"
> > + depends on RFKILL || !RFKILL
>
> That looks *odd*.
Taken from Documentation/rfkill.txt section 3. Kernel API.
I guess I can drop it if we want to be stricter and just require RFKILL
to be enabled. Johannes?
> Otherwise this looks fine from a regulator API point
> of view. You use an exclusive get() so you could get away without
> remembering the enable state as nothing else could hold the device open
> but there's no harm in doing so and it's defensive against silly
> constraints that force the regulator on.
>
Thanks Mark.
Regards,
Antonio
--
Antonio Ospite
http://ao2.it
PGP public key ID: 0x4553B001
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-04-06 14:29 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 9:21 [PATCH] rfkill: Regulator consumer driver for rfkill Antonio Ospite
2011-04-06 9:29 ` Johannes Berg
2011-04-06 14:06 ` Antonio Ospite
2011-04-06 14:09 ` Johannes Berg
2011-04-06 14:24 ` Antonio Ospite
2011-04-06 14:50 ` Joey Lee
2011-04-08 10:59 ` [PATCH v2] " Antonio Ospite
2011-04-12 11:41 ` Johannes Berg
2011-04-12 11:44 ` Johannes Berg
2011-04-12 15:15 ` Mark Brown
2011-04-12 15:23 ` Johannes Berg
2011-04-13 16:53 ` Mark Brown
2011-04-13 8:44 ` Antonio Ospite
2011-04-13 9:19 ` Johannes Berg
2011-04-13 19:40 ` [PATCH v3] " Antonio Ospite
2011-04-13 19:53 ` Johannes Berg
2011-04-14 10:39 ` Antonio Ospite
2011-04-14 13:06 ` Mark Brown
2011-04-15 10:24 ` Antonio Ospite
2011-04-13 8:53 ` [PATCH v2] " Antonio Ospite
2011-04-06 14:11 ` [PATCH] " Mark Brown
2011-04-06 14:21 ` Johannes Berg
2011-04-06 18:12 ` Paul Bolle
2011-04-06 18:38 ` John W. Linville
2011-04-06 20:10 ` Paul Bolle
2011-04-06 20:15 ` Johannes Berg
2011-04-06 20:17 ` Johannes Berg
2011-04-06 20:19 ` Johannes Berg
2011-04-06 18:46 ` Johannes Berg
2011-04-07 10:01 ` Bernd Petrovitsch
2011-04-07 10:09 ` Johannes Berg
2011-04-07 10:33 ` Bernd Petrovitsch
2011-04-06 14:29 ` Antonio Ospite [this message]
2011-04-06 14:32 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110406162901.0efa11ad.ospite@studenti.unina.it \
--to=ospite@studenti.unina.it \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gmzhuo@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrg@slimlogic.co.uk \
--cc=marek.vasut@gmail.com \
--cc=openezx-devel@lists.openezx.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).