From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:40034 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755520Ab1DKTAZ (ORCPT ); Mon, 11 Apr 2011 15:00:25 -0400 Date: Mon, 11 Apr 2011 14:58:36 -0400 From: "John W. Linville" To: wwguy Cc: "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Dave Airlie , Stanislaw Gruszka Subject: Re: [PATCH] iwlegacy: make iwl3945 and iwl4965 select IWLWIFI_LEGACY Message-ID: <20110411185807.GC2511@tuxdriver.com> References: <1302541599-15383-1-git-send-email-linville@tuxdriver.com> <1302547162.5663.2.camel@wwguy-ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1302547162.5663.2.camel@wwguy-ubuntu> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Apr 11, 2011 at 11:39:22AM -0700, wwguy wrote: > On Mon, 2011-04-11 at 10:06 -0700, John W. Linville wrote: > > Otherwise, IWLWIFI_LEGACY has to be selected independently before the > > drivers are made available. > > > > Reported-by: Dave Airlie > > Signed-off-by: John W. Linville > > Cc: Stanislaw Gruszka > > Cc: Wey-Yi Guy > > --- > > drivers/net/wireless/iwlegacy/Kconfig | 9 +++++---- > > 1 files changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/wireless/iwlegacy/Kconfig b/drivers/net/wireless/iwlegacy/Kconfig > > index 2a45dd4..aef65cd 100644 > > --- a/drivers/net/wireless/iwlegacy/Kconfig > > +++ b/drivers/net/wireless/iwlegacy/Kconfig > > @@ -1,6 +1,5 @@ > > config IWLWIFI_LEGACY > > - tristate "Intel Wireless Wifi legacy devices" > > - depends on PCI && MAC80211 > > + tristate > > select FW_LOADER > > select NEW_LEDS > > select LEDS_CLASS > > Should we add some ---help--- here?, or not.. Why would you need it? This is now automatically selected by the driver -- the user doesn't see it. -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.