* [PATCH] iwlegacy: make iwl3945 and iwl4965 select IWLWIFI_LEGACY [not found] <BANLkTimoDVMcvFdoUedyfw4Thv8=DsV-5A@mail.gmail.com> @ 2011-04-11 17:06 ` John W. Linville 2011-04-11 18:39 ` wwguy 0 siblings, 1 reply; 3+ messages in thread From: John W. Linville @ 2011-04-11 17:06 UTC (permalink / raw) To: linux-wireless Cc: linux-kernel, Dave Airlie, John W. Linville, Stanislaw Gruszka, Wey-Yi Guy Otherwise, IWLWIFI_LEGACY has to be selected independently before the drivers are made available. Reported-by: Dave Airlie <airlied@gmail.com> Signed-off-by: John W. Linville <linville@tuxdriver.com> Cc: Stanislaw Gruszka <sgruszka@redhat.com> Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com> --- drivers/net/wireless/iwlegacy/Kconfig | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/iwlegacy/Kconfig b/drivers/net/wireless/iwlegacy/Kconfig index 2a45dd4..aef65cd 100644 --- a/drivers/net/wireless/iwlegacy/Kconfig +++ b/drivers/net/wireless/iwlegacy/Kconfig @@ -1,6 +1,5 @@ config IWLWIFI_LEGACY - tristate "Intel Wireless Wifi legacy devices" - depends on PCI && MAC80211 + tristate select FW_LOADER select NEW_LEDS select LEDS_CLASS @@ -65,7 +64,8 @@ endmenu config IWL4965 tristate "Intel Wireless WiFi 4965AGN (iwl4965)" - depends on IWLWIFI_LEGACY + depends on PCI && MAC80211 + select IWLWIFI_LEGACY ---help--- This option enables support for @@ -92,7 +92,8 @@ config IWL4965 config IWL3945 tristate "Intel PRO/Wireless 3945ABG/BG Network Connection (iwl3945)" - depends on IWLWIFI_LEGACY + depends on PCI && MAC80211 + select IWLWIFI_LEGACY ---help--- Select to build the driver supporting the: -- 1.7.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iwlegacy: make iwl3945 and iwl4965 select IWLWIFI_LEGACY 2011-04-11 17:06 ` [PATCH] iwlegacy: make iwl3945 and iwl4965 select IWLWIFI_LEGACY John W. Linville @ 2011-04-11 18:39 ` wwguy 2011-04-11 18:58 ` John W. Linville 0 siblings, 1 reply; 3+ messages in thread From: wwguy @ 2011-04-11 18:39 UTC (permalink / raw) To: John W. Linville Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Airlie, Stanislaw Gruszka On Mon, 2011-04-11 at 10:06 -0700, John W. Linville wrote: > Otherwise, IWLWIFI_LEGACY has to be selected independently before the > drivers are made available. > > Reported-by: Dave Airlie <airlied@gmail.com> > Signed-off-by: John W. Linville <linville@tuxdriver.com> > Cc: Stanislaw Gruszka <sgruszka@redhat.com> > Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com> > --- > drivers/net/wireless/iwlegacy/Kconfig | 9 +++++---- > 1 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/iwlegacy/Kconfig b/drivers/net/wireless/iwlegacy/Kconfig > index 2a45dd4..aef65cd 100644 > --- a/drivers/net/wireless/iwlegacy/Kconfig > +++ b/drivers/net/wireless/iwlegacy/Kconfig > @@ -1,6 +1,5 @@ > config IWLWIFI_LEGACY > - tristate "Intel Wireless Wifi legacy devices" > - depends on PCI && MAC80211 > + tristate > select FW_LOADER > select NEW_LEDS > select LEDS_CLASS Should we add some ---help--- here?, or not.. Wey ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iwlegacy: make iwl3945 and iwl4965 select IWLWIFI_LEGACY 2011-04-11 18:39 ` wwguy @ 2011-04-11 18:58 ` John W. Linville 0 siblings, 0 replies; 3+ messages in thread From: John W. Linville @ 2011-04-11 18:58 UTC (permalink / raw) To: wwguy Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Airlie, Stanislaw Gruszka On Mon, Apr 11, 2011 at 11:39:22AM -0700, wwguy wrote: > On Mon, 2011-04-11 at 10:06 -0700, John W. Linville wrote: > > Otherwise, IWLWIFI_LEGACY has to be selected independently before the > > drivers are made available. > > > > Reported-by: Dave Airlie <airlied@gmail.com> > > Signed-off-by: John W. Linville <linville@tuxdriver.com> > > Cc: Stanislaw Gruszka <sgruszka@redhat.com> > > Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com> > > --- > > drivers/net/wireless/iwlegacy/Kconfig | 9 +++++---- > > 1 files changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/wireless/iwlegacy/Kconfig b/drivers/net/wireless/iwlegacy/Kconfig > > index 2a45dd4..aef65cd 100644 > > --- a/drivers/net/wireless/iwlegacy/Kconfig > > +++ b/drivers/net/wireless/iwlegacy/Kconfig > > @@ -1,6 +1,5 @@ > > config IWLWIFI_LEGACY > > - tristate "Intel Wireless Wifi legacy devices" > > - depends on PCI && MAC80211 > > + tristate > > select FW_LOADER > > select NEW_LEDS > > select LEDS_CLASS > > Should we add some ---help--- here?, or not.. Why would you need it? This is now automatically selected by the driver -- the user doesn't see it. -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-11 19:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <BANLkTimoDVMcvFdoUedyfw4Thv8=DsV-5A@mail.gmail.com>
2011-04-11 17:06 ` [PATCH] iwlegacy: make iwl3945 and iwl4965 select IWLWIFI_LEGACY John W. Linville
2011-04-11 18:39 ` wwguy
2011-04-11 18:58 ` John W. Linville
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).