From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from kroah.org ([198.145.64.141]:42052 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754258Ab1DKVZQ (ORCPT ); Mon, 11 Apr 2011 17:25:16 -0400 Date: Mon, 11 Apr 2011 14:25:13 -0700 From: Greg KH To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: linux-wireless@vger.kernel.org, "John W. Linville" , George Kashperko , Arnd Bergmann , Russell King , "linux-kernel@vger.kernel.org" , b43-dev@lists.infradead.org, Michael =?iso-8859-1?Q?B=FCsch?= , linuxdriverproject , Andy Botting , "linux-arm-kernel@lists.infradead.org" , Larry Finger Subject: Re: [RFC][PATCH V3] axi: add AXI bus driver Message-ID: <20110411212513.GA17809@kroah.com> References: <1302557114-7880-1-git-send-email-zajec5@gmail.com> <20110411210631.GA28559@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Apr 11, 2011 at 11:19:13PM +0200, Rafał Miłecki wrote: > 2011/4/11 Greg KH : > > On Mon, Apr 11, 2011 at 11:25:14PM +0200, Rafał Miłecki wrote: > >> +static void axi_release_core_dev(struct device *dev) > >> +{ > >> +     /* Silent lack-of-release warning */ > >> +} > > > > Ok, WTF!!!! > > Thank you for your kindly words. It's much more enjoyable to work on > kernel that way. I definitely made that on purpose. I can't tell if you are kidding or not. Please read the documentation for how to do this properly. I find it really hard to believe that you wrote that comment instead of putting in the 2 lines of code required for this function. Especially as-it-is, your code does not work properly and leaks memory badly. Why would you do that on purpose? thanks, greg k-h