From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net
Subject: Re: [PATCH 10/16] iwlagn: remove un-needed configuration
Date: Tue, 12 Apr 2011 12:41:39 +0200 [thread overview]
Message-ID: <20110412104139.GC2804@redhat.com> (raw)
In-Reply-To: <20110412103905.GB2804@redhat.com>
On Tue, Apr 12, 2011 at 12:39:05PM +0200, Stanislaw Gruszka wrote:
> On Fri, Apr 08, 2011 at 08:30:30AM -0700, Wey-Yi Guy wrote:
> > + lctl = iwl_pcie_link_ctl(priv);
> > + if ((lctl & PCI_CFG_LINK_CTRL_VAL_L1_EN) ==
> > + PCI_CFG_LINK_CTRL_VAL_L1_EN) {
> > + /* L1-ASPM enabled; disable(!) L0S */
> > + iwl_set_bit(priv, CSR_GIO_REG,
> > + CSR_GIO_REG_VAL_L0S_ENABLED);
> > + IWL_DEBUG_POWER(priv, "L1 Enabled; Disabling L0S\n");
> > + } else {
> > + /* L1-ASPM disabled; enable(!) L0S */
We claim to enable L0S,
> > + iwl_clear_bit(priv, CSR_GIO_REG,
> > + CSR_GIO_REG_VAL_L0S_ENABLED);
but we clear CSR_GIO_REG_VAL_L0S_ENABLED bit, hmm ...
next prev parent reply other threads:[~2011-04-12 10:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 15:30 [PATCH 00/16] update for 2.6.40 Wey-Yi Guy
2011-04-08 15:30 ` [PATCH 01/16] iwlwifi: remove extranious macro from firmware define Wey-Yi Guy
2011-04-08 15:30 ` [PATCH 02/16] iwlagn: remove un-necessary function pointer Wey-Yi Guy
2011-04-08 15:30 ` [PATCH 03/16] iwlagn: fix radar frame rejection Wey-Yi Guy
2011-04-10 8:15 ` Johannes Berg
2011-04-10 15:29 ` Guy, Wey-Yi
2011-04-08 15:30 ` [PATCH 04/16] iwlwifi: fix bugs in change_interface Wey-Yi Guy
2011-04-10 8:15 ` Johannes Berg
2011-04-10 15:37 ` Guy, Wey-Yi
2011-04-08 15:30 ` [PATCH 05/16] iwlagn: PAPD read for 2000 series devices Wey-Yi Guy
2011-04-08 15:30 ` [PATCH 06/16] iwlagn: no 3945 define needed Wey-Yi Guy
2011-04-08 15:30 ` [PATCH 07/16] iwlagn: remove unused 3945 define Wey-Yi Guy
2011-04-08 15:30 ` [PATCH 08/16] iwlagn: cleanup to remove the reference for 3945 Wey-Yi Guy
2011-04-08 15:30 ` [PATCH 09/16] iwlagn: remove more reference to legacy devices Wey-Yi Guy
2011-04-08 15:30 ` [PATCH 10/16] iwlagn: remove un-needed configuration Wey-Yi Guy
2011-04-12 10:39 ` Stanislaw Gruszka
2011-04-12 10:41 ` Stanislaw Gruszka [this message]
2011-04-12 14:39 ` wwguy
2011-04-08 15:30 ` [PATCH 11/16] iwlagn: more cleanup to remove unused reference Wey-Yi Guy
2011-04-08 15:30 ` [PATCH 12/16] iwlagn: all _agn devices support power save mode Wey-Yi Guy
2011-04-08 15:30 ` [PATCH 13/16] iwlagn: tx power calib always done in firmware Wey-Yi Guy
2011-04-08 15:30 ` [PATCH 14/16] iwlagn: sensitivity and chain noise done by driver Wey-Yi Guy
2011-04-08 15:30 ` [PATCH 15/16] iwlagn: clean up & autodetect statistics Wey-Yi Guy
2011-04-08 15:30 ` [PATCH 16/16] iwlagn: downgrade warning on unknown TLV Wey-Yi Guy
2011-04-10 8:15 ` Johannes Berg
2011-04-10 15:34 ` Guy, Wey-Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110412104139.GC2804@redhat.com \
--to=sgruszka@redhat.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).