* [PATCH 2/2] mwl8k: setting IEEE80211_HW_CRYPTO_ENABLED for AP mode
@ 2011-04-15 4:54 Yogesh Ashok Powar
2011-04-15 7:00 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Yogesh Ashok Powar @ 2011-04-15 4:54 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless, Lennert Buytenhek
For AP mode, driver sets IEEE80211_HW_CRYPTO_ENABLED hardware flag to avoid
mac80211 reserving tail room space for crypto suite.
Signed-off-by: Yogesh Ashok Powar <yogeshp@marvell.com>
---
drivers/net/wireless/mwl8k.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c
index 28ebaec..7ddc9ca 100644
--- a/drivers/net/wireless/mwl8k.c
+++ b/drivers/net/wireless/mwl8k.c
@@ -5472,6 +5472,10 @@ static int mwl8k_firmware_load_success(struct mwl8k_priv *priv)
/* Set rssi values to dBm */
hw->flags |= IEEE80211_HW_SIGNAL_DBM | IEEE80211_HW_HAS_RATE_CONTROL;
+
+ /* This is needed to avoid tailroom calculations */
+ hw->flags |= priv->ap_fw ? IEEE80211_HW_CRYPTO_ENABLED : 0;
+
hw->vif_data_size = sizeof(struct mwl8k_vif);
hw->sta_data_size = sizeof(struct mwl8k_sta);
--
1.7.3.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] mwl8k: setting IEEE80211_HW_CRYPTO_ENABLED for AP mode
2011-04-15 4:54 [PATCH 2/2] mwl8k: setting IEEE80211_HW_CRYPTO_ENABLED for AP mode Yogesh Ashok Powar
@ 2011-04-15 7:00 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2011-04-15 7:00 UTC (permalink / raw)
To: Yogesh Ashok Powar; +Cc: John W. Linville, linux-wireless, Lennert Buytenhek
Yogesh Ashok Powar <yogeshp@marvell.com> writes:
> For AP mode, driver sets IEEE80211_HW_CRYPTO_ENABLED hardware flag to avoid
> mac80211 reserving tail room space for crypto suite.
A small style issue:
> + /* This is needed to avoid tailroom calculations */
> + hw->flags |= priv->ap_fw ? IEEE80211_HW_CRYPTO_ENABLED : 0;
Why not just:
if (priv->ap_fw)
hw->flags |= IEEE80211_HW_CRYPTO_ENABLED
A lot easier to read.
--
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-15 7:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-15 4:54 [PATCH 2/2] mwl8k: setting IEEE80211_HW_CRYPTO_ENABLED for AP mode Yogesh Ashok Powar
2011-04-15 7:00 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).