From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: Kalle Valo <kvalo@adurom.com>
Cc: Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 02/22] ath9k_hw: Take care of few host interface register changes for AR9340
Date: Tue, 19 Apr 2011 11:26:20 +0530 [thread overview]
Message-ID: <20110419055620.GC21802@vasanth-laptop> (raw)
In-Reply-To: <87sjtml8cw.fsf@purkki.adurom.net>
On Wed, Apr 13, 2011 at 04:35:19PM +0530, Kalle Valo wrote:
> Vasanthakumar Thiagarajan <vasanth@atheros.com> writes:
>
> > -#define AR_WA 0x4004
> > +#define AR_WA (AR_SREV_9340(ah) ? 0x40c4 : 0x4004)
>
> So now allthe macros require this ah variable? That's confusing as
> that's not visible when using the macro.
All register read/write functions require ath9k hw structure (ah) to
be available anyway, so it is reasonable to assume that ah will be available to
determine that register offset as well.
Vasanth
next prev parent reply other threads:[~2011-04-19 5:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 12:57 [PATCH 00/22] Add support for AR9340 Vasanthakumar Thiagarajan
2011-04-12 12:57 ` [PATCH 01/22] ath9k_hw: Define devid and mac version " Vasanthakumar Thiagarajan
2011-04-12 12:57 ` [PATCH 02/22] ath9k_hw: Take care of few host interface register changes " Vasanthakumar Thiagarajan
2011-04-13 11:05 ` Kalle Valo
2011-04-19 5:56 ` Vasanthakumar Thiagarajan [this message]
2011-04-12 12:57 ` [PATCH 05/22] ath9k_hw: Add initvals.h for ar9340 Vasanthakumar Thiagarajan
2011-04-12 12:57 ` [PATCH 08/22] ath9k_hw: Initialize tx and rx gain table from " Vasanthakumar Thiagarajan
2011-04-12 12:57 ` [PATCH 12/22] ath9k_hw: Fix register offset AR_PHY_65NM_CH0_THERM for AR9340 Vasanthakumar Thiagarajan
2011-04-12 12:57 ` [PATCH 13/22] ath9k_hw: Don't configure AR_CH0_THERM " Vasanthakumar Thiagarajan
2011-04-12 12:57 ` [PATCH 16/22] ath9k_hw: Enable byte Tx/Rx data swap " Vasanthakumar Thiagarajan
2011-04-12 12:57 ` [PATCH 19/22] ath9k: Add AR9340 platform id to id table Vasanthakumar Thiagarajan
2011-04-12 12:57 ` [PATCH 20/22] ath9k_hw: Assign macversion based on devid for built-in wmac Vasanthakumar Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110419055620.GC21802@vasanth-laptop \
--to=vasanth@atheros.com \
--cc=Vasanth.Thiagarajan@Atheros.com \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).