From: Lennert Buytenhek <buytenh@wantstofly.org>
To: Nishant Sarmukadam <nishants@marvell.com>
Cc: linux-wireless@vger.kernel.org, Pradeep Nemavat <pnemavat@marvell.com>
Subject: Re: [PATCH V2 3/4] mwl8k: Reserve buffers for tx management frames
Date: Thu, 21 Apr 2011 09:44:36 +0200 [thread overview]
Message-ID: <20110421074436.GY1897@wantstofly.org> (raw)
In-Reply-To: <1303231582-17333-3-git-send-email-nishants@marvell.com>
On Tue, Apr 19, 2011 at 10:16:21PM +0530, Nishant Sarmukadam wrote:
> - if (txq->len >= MWL8K_TX_DESCS) {
> - if (start_ba_session) {
> - spin_lock(&priv->stream_lock);
> - mwl8k_remove_stream(hw, stream);
> - spin_unlock(&priv->stream_lock);
> + /* Mgmt frames that go out frequently are probe responses.
> + * Other mgmt frames got out relatively infrequently.
> + * Hence reserve 2 buffers so that other mgmt frames do not get
> + * dropped due to an already queued probe response in one of
> + * the reserved buffers.
> + */
Comment formatting..
> + if (txq->len >= (MWL8K_TX_DESCS - 2)) {
> + if ((mgmtframe == false) ||
> + (txq->len == MWL8K_TX_DESCS)) {
> + if (start_ba_session) {
> + spin_lock(&priv->stream_lock);
> + mwl8k_remove_stream(hw, stream);
> + spin_unlock(&priv->stream_lock);
> + }
..and lots of superfluous parentheses here:
txq->len >= MWL8K_TX_DESCS - 2
mgmtframe == false
txq->len == MWL8K_TX_DESCS
next prev parent reply other threads:[~2011-04-21 7:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 16:46 [PATCH V2 1/4] mwl8k: Do not stop tx queues Nishant Sarmukadam
2011-04-19 16:46 ` [PATCH V2 2/4] mwl8k: Add timestamp information for tx packets Nishant Sarmukadam
2011-04-21 7:42 ` Lennert Buytenhek
2011-04-21 8:15 ` Nishant Sarmukadam
2011-04-19 16:46 ` [PATCH V2 3/4] mwl8k: Reserve buffers for tx management frames Nishant Sarmukadam
2011-04-21 7:44 ` Lennert Buytenhek [this message]
2011-04-21 8:15 ` Nishant Sarmukadam
2011-04-19 16:46 ` [PATCH V2 4/4] mwl8k: Enable life time expiry for tx packets in the hardware Nishant Sarmukadam
2011-04-21 7:38 ` [PATCH V2 1/4] mwl8k: Do not stop tx queues Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110421074436.GY1897@wantstofly.org \
--to=buytenh@wantstofly.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
--cc=pnemavat@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox