From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: Mohammed Shafi Shajakhan <mshajakhan@atheros.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
Senthilkumar Balasubramanian
<Senthilkumar.Balasubramanian@Atheros.com>,
Mohammed Shajakhan <Mohammed.Shajakhan@Atheros.com>
Subject: Re: [RFC/RFT 3/9] ath9k_hw: define registers/macros to support Antenna diversity
Date: Fri, 29 Apr 2011 09:50:18 +0530 [thread overview]
Message-ID: <20110429042018.GB26690@vasanth-laptop> (raw)
In-Reply-To: <1304000579-5784-4-git-send-email-mshajakhan@atheros.com>
On Thu, Apr 28, 2011 at 07:52:53PM +0530, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan <mshajakhan@atheros.com>
>
> define few registers and macros to configure/enable Antenna diversity
> parameters in AR9485
>
> Signed-off-by: Mohammed Shafi Shajakhan <mshajakhan@atheros.com>
> ---
> drivers/net/wireless/ath/ath9k/ar9003_phy.h | 31 ++++++++++++++++++++++++--
> drivers/net/wireless/ath/ath9k/hw.h | 3 ++
> 2 files changed, 31 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_phy.h b/drivers/net/wireless/ath/ath9k/ar9003_phy.h
> index 2a0d5cb..c4f409f 100644
> --- a/drivers/net/wireless/ath/ath9k/ar9003_phy.h
> +++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.h
> @@ -245,6 +245,9 @@
> */
> #define AR_BBB_BASE 0x9d00
>
> +#define AR_BBB_SIG_DETECT_ANT_FAST_DIV 0x00002000
> +#define AR_BBB_SIG_DETECT_ANT_FAST_DIV_S 13
> +
> /*
> * AGC Register Map
> */
> @@ -261,12 +264,37 @@
> #define AR_PHY_EXT_CCA0 (AR_AGC_BASE + 0x20)
> #define AR_PHY_RESTART (AR_AGC_BASE + 0x24)
>
> +/*
> + * Antenna Diversity settings
> + */
> #define AR_PHY_MC_GAIN_CTRL (AR_AGC_BASE + 0x28)
> #define AR_ANT_DIV_CTRL_ALL 0x7e000000
> #define AR_ANT_DIV_CTRL_ALL_S 25
> #define AR_ANT_DIV_ENABLE 0x1000000
> #define AR_ANT_DIV_ENABLE_S 24
>
> +#define AR_PHY_CCK_DETECT (AR_AGC_BASE + 0x1c0)
> +#define AR_FAST_DIV_ENABLE 0x2000
> +#define AR_FAST_DIV_ENABLE_S 13
This can be in the original place as it is in order with the
register offset. This way we can avoid any possible duplication/bug
in register definition.
Vasanth
next prev parent reply other threads:[~2011-04-29 4:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 14:22 [RFC/RFT 0/9] ath9k: Add Antenna diversity support for AR9485 Mohammed Shafi Shajakhan
2011-04-28 14:22 ` [RFC/RFT 1/9] ath9k_hw: make antenna diversity modules chip specific Mohammed Shafi Shajakhan
2011-04-29 4:10 ` Vasanthakumar Thiagarajan
2011-04-29 5:21 ` Mohammed Shafi
2011-04-28 14:22 ` [RFC/RFT 2/9] ath9k_hw: enable Antenna diversity for AR9485 Mohammed Shafi Shajakhan
2011-04-28 14:22 ` [RFC/RFT 3/9] ath9k_hw: define registers/macros to support Antenna diversity Mohammed Shafi Shajakhan
2011-04-29 4:20 ` Vasanthakumar Thiagarajan [this message]
2011-04-29 4:53 ` Mohammed Shafi
2011-04-28 14:22 ` [RFC/RFT 4/9] ath9k_hw: config diversity based on eeprom contents Mohammed Shafi Shajakhan
2011-04-28 17:39 ` Luis R. Rodriguez
2011-04-29 4:52 ` Mohammed Shafi
2011-04-29 4:43 ` Vasanthakumar Thiagarajan
2011-04-29 6:34 ` Mohammed Shafi
2011-04-29 6:49 ` Mohammed Shafi
2011-04-28 14:22 ` [RFC/RFT 5/9] ath9k_hw: define modules to get/set Antenna diversity paramaters Mohammed Shafi Shajakhan
2011-04-28 14:22 ` [RFC/RFT 6/9] ath9k_hw: define antenna diversity group Mohammed Shafi Shajakhan
2011-04-28 14:22 ` [RFC/RFT 7/9] ath9k: Implement an API to swap main/ALT LNA's Mohammed Shafi Shajakhan
2011-04-28 14:22 ` [RFC/RFT 8/9] ath9k: configure fast_div_bias based on diversity group Mohammed Shafi Shajakhan
2011-04-28 14:22 ` [RFC/RFT 9/9] ath9k: make sure main_rssi is positive Mohammed Shafi Shajakhan
2011-04-28 18:12 ` [RFC/RFT 0/9] ath9k: Add Antenna diversity support for AR9485 Luis R. Rodriguez
2011-04-28 18:12 ` Luis R. Rodriguez
2011-04-29 4:52 ` Mohammed Shafi
2011-05-12 16:59 ` John W. Linville
2011-05-13 4:22 ` Mohammed Shafi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110429042018.GB26690@vasanth-laptop \
--to=vasanth@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=Mohammed.Shajakhan@Atheros.com \
--cc=Senthilkumar.Balasubramanian@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mshajakhan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).