From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: Greg KH <greg@kroah.com>
Cc: Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Vipin Mehta" <Vipin.Mehta@Atheros.com>,
Naveen Singh <Naveen.Singh@Atheros.com>
Subject: Re: [PATCH 1/2] ath6kl: Remove dead code with undefined EXPORT_HCI_BRIDGE_INTERFACE
Date: Sat, 7 May 2011 21:32:22 +0530 [thread overview]
Message-ID: <20110507160222.GB17465@vasanth-laptop> (raw)
In-Reply-To: <20110507154228.GD23672@kroah.com>
On Sat, May 07, 2011 at 09:12:28PM +0530, Greg KH wrote:
> On Sat, May 07, 2011 at 03:59:07PM +0530, Vasanthakumar Thiagarajan wrote:
> > On Fri, May 06, 2011 at 10:03:20PM +0530, Greg KH wrote:
> > > On Wed, May 04, 2011 at 09:28:10PM +0530, Vasanthakumar Thiagarajan wrote:
> > > > Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
> > >
> > > It's not as dead as you think it is, this series causes a build
> > > breakage.
> > >
> > > PLEASE TEST YOUR PATCHES!
> > >
> > > To not do so, like you did here just makes me grumpy and not want to
> > > deal with them at all...
> >
> > I'm really sorry for any trouble with those patches. I do compile
> > and test my patches. Unfortunately I do not see the build breakage
> > with that patch series. Can you please share you config file?.
>
> Attached.
Really sorry again. I mistakenly moved a global variable
to #ifdef ATH_DEBUG_MODULE. As I was testing with debug
enabled I did not hit this issue.
Thanks,
Vasanth
prev parent reply other threads:[~2011-05-07 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 15:58 [PATCH 1/2] ath6kl: Remove dead code with undefined EXPORT_HCI_BRIDGE_INTERFACE Vasanthakumar Thiagarajan
2011-05-04 15:58 ` [PATCH 2/2] ath6kl: Merge Bootloader Management Interface (BMI) related header files into one Vasanthakumar Thiagarajan
2011-05-06 16:33 ` [PATCH 1/2] ath6kl: Remove dead code with undefined EXPORT_HCI_BRIDGE_INTERFACE Greg KH
2011-05-07 10:29 ` Vasanthakumar Thiagarajan
2011-05-07 15:42 ` Greg KH
2011-05-07 16:02 ` Vasanthakumar Thiagarajan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110507160222.GB17465@vasanth-laptop \
--to=vasanth@atheros.com \
--cc=Naveen.Singh@Atheros.com \
--cc=Vasanth.Thiagarajan@Atheros.com \
--cc=Vipin.Mehta@Atheros.com \
--cc=devel@linuxdriverproject.org \
--cc=greg@kroah.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).