* [RFC] ath9k: make npending frames check as bool @ 2011-05-06 15:54 Mohammed Shafi Shajakhan 2011-05-06 16:15 ` Vasanthakumar Thiagarajan 0 siblings, 1 reply; 6+ messages in thread From: Mohammed Shafi Shajakhan @ 2011-05-06 15:54 UTC (permalink / raw) To: linux-wireless; +Cc: ath9k-devel, Mohammed Shafi Shajakhan From: Mohammed Shafi Shajakhan <mshajakhan@atheros.com> Signed-off-by: Mohammed Shafi Shajakhan <mshajakhan@atheros.com> --- drivers/net/wireless/ath/ath9k/main.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c index 3de115d..2b78ea2 100644 --- a/drivers/net/wireless/ath/ath9k/main.c +++ b/drivers/net/wireless/ath/ath9k/main.c @@ -2267,7 +2267,7 @@ static void ath9k_flush(struct ieee80211_hw *hw, bool drop) timeout = 1; for (j = 0; j < timeout; j++) { - int npend = 0; + bool npend = false; if (j) usleep_range(1000, 2000); @@ -2276,7 +2276,10 @@ static void ath9k_flush(struct ieee80211_hw *hw, bool drop) if (!ATH_TXQ_SETUP(sc, i)) continue; - npend += ath9k_has_pending_frames(sc, &sc->tx.txq[i]); + npend = ath9k_has_pending_frames(sc, &sc->tx.txq[i]); + + if (npend) + break; } if (!npend) -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RFC] ath9k: make npending frames check as bool 2011-05-06 15:54 [RFC] ath9k: make npending frames check as bool Mohammed Shafi Shajakhan @ 2011-05-06 16:15 ` Vasanthakumar Thiagarajan 2011-05-09 4:30 ` Mohammed Shafi 0 siblings, 1 reply; 6+ messages in thread From: Vasanthakumar Thiagarajan @ 2011-05-06 16:15 UTC (permalink / raw) To: Mohammed Shafi Shajakhan Cc: linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org, Mohammed Shajakhan On Fri, May 06, 2011 at 09:24:51PM +0530, Mohammed Shafi Shajakhan wrote: > From: Mohammed Shafi Shajakhan <mshajakhan@atheros.com> > > Signed-off-by: Mohammed Shafi Shajakhan <mshajakhan@atheros.com> > --- > drivers/net/wireless/ath/ath9k/main.c | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c > index 3de115d..2b78ea2 100644 > --- a/drivers/net/wireless/ath/ath9k/main.c > +++ b/drivers/net/wireless/ath/ath9k/main.c > @@ -2267,7 +2267,7 @@ static void ath9k_flush(struct ieee80211_hw *hw, bool drop) > timeout = 1; > > for (j = 0; j < timeout; j++) { > - int npend = 0; > + bool npend = false; > > if (j) > usleep_range(1000, 2000); > @@ -2276,7 +2276,10 @@ static void ath9k_flush(struct ieee80211_hw *hw, bool drop) > if (!ATH_TXQ_SETUP(sc, i)) > continue; > > - npend += ath9k_has_pending_frames(sc, &sc->tx.txq[i]); > + npend = ath9k_has_pending_frames(sc, &sc->tx.txq[i]); > + > + if (npend) > + break; We need not bail out as soon as there is a pending frame in a queue. There is a possibility that it could be transmitted successfully by the time the given timeout expires. Vasanth ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] ath9k: make npending frames check as bool 2011-05-06 16:15 ` Vasanthakumar Thiagarajan @ 2011-05-09 4:30 ` Mohammed Shafi 2011-05-09 9:28 ` Vasanthakumar Thiagarajan 0 siblings, 1 reply; 6+ messages in thread From: Mohammed Shafi @ 2011-05-09 4:30 UTC (permalink / raw) To: Vasanth Thiagarajan Cc: Mohammed Shajakhan, linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org On Friday 06 May 2011 09:45 PM, Vasanth Thiagarajan wrote: > On Fri, May 06, 2011 at 09:24:51PM +0530, Mohammed Shafi Shajakhan wrote: >> From: Mohammed Shafi Shajakhan<mshajakhan@atheros.com> >> >> Signed-off-by: Mohammed Shafi Shajakhan<mshajakhan@atheros.com> >> --- >> drivers/net/wireless/ath/ath9k/main.c | 7 +++++-- >> 1 files changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c >> index 3de115d..2b78ea2 100644 >> --- a/drivers/net/wireless/ath/ath9k/main.c >> +++ b/drivers/net/wireless/ath/ath9k/main.c >> @@ -2267,7 +2267,7 @@ static void ath9k_flush(struct ieee80211_hw *hw, bool drop) >> timeout = 1; >> >> for (j = 0; j< timeout; j++) { >> - int npend = 0; >> + bool npend = false; >> >> if (j) >> usleep_range(1000, 2000); >> @@ -2276,7 +2276,10 @@ static void ath9k_flush(struct ieee80211_hw *hw, bool drop) >> if (!ATH_TXQ_SETUP(sc, i)) >> continue; >> >> - npend += ath9k_has_pending_frames(sc,&sc->tx.txq[i]); >> + npend = ath9k_has_pending_frames(sc,&sc->tx.txq[i]); >> + >> + if (npend) >> + break; > > We need not bail out as soon as there is a pending frame in a queue. > There is a possibility that it could be transmitted successfully by > the time the given timeout expires. Hi Vasanth, the timeout is before we enter into the loop for checking pending frames, so I thought it won't be affecting it. am I missing something? please tell me. thanks, shafi > > Vasanth > . > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] ath9k: make npending frames check as bool 2011-05-09 4:30 ` Mohammed Shafi @ 2011-05-09 9:28 ` Vasanthakumar Thiagarajan 2011-05-09 9:39 ` Vasanthakumar Thiagarajan 2011-05-09 9:39 ` Mohammed Shafi 0 siblings, 2 replies; 6+ messages in thread From: Vasanthakumar Thiagarajan @ 2011-05-09 9:28 UTC (permalink / raw) To: Mohammed Shajakhan Cc: Vasanth Thiagarajan, linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org On Mon, May 09, 2011 at 10:00:17AM +0530, Mohammed Shajakhan wrote: > On Friday 06 May 2011 09:45 PM, Vasanth Thiagarajan wrote: > > On Fri, May 06, 2011 at 09:24:51PM +0530, Mohammed Shafi Shajakhan wrote: > >> From: Mohammed Shafi Shajakhan<mshajakhan@atheros.com> > >> > >> Signed-off-by: Mohammed Shafi Shajakhan<mshajakhan@atheros.com> > >> --- > >> drivers/net/wireless/ath/ath9k/main.c | 7 +++++-- > >> 1 files changed, 5 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c > >> index 3de115d..2b78ea2 100644 > >> --- a/drivers/net/wireless/ath/ath9k/main.c > >> +++ b/drivers/net/wireless/ath/ath9k/main.c > >> @@ -2267,7 +2267,7 @@ static void ath9k_flush(struct ieee80211_hw *hw, bool drop) > >> timeout = 1; > >> > >> for (j = 0; j< timeout; j++) { > >> - int npend = 0; > >> + bool npend = false; > >> > >> if (j) > >> usleep_range(1000, 2000); > >> @@ -2276,7 +2276,10 @@ static void ath9k_flush(struct ieee80211_hw *hw, bool drop) > >> if (!ATH_TXQ_SETUP(sc, i)) > >> continue; > >> > >> - npend += ath9k_has_pending_frames(sc,&sc->tx.txq[i]); > >> + npend = ath9k_has_pending_frames(sc,&sc->tx.txq[i]); > >> + > >> + if (npend) > >> + break; > > > > We need not bail out as soon as there is a pending frame in a queue. > > There is a possibility that it could be transmitted successfully by > > the time the given timeout expires. > > Hi Vasanth, > the timeout is before we enter into the loop for checking pending > frames, so I thought it won't be affecting it. am I missing something? > please tell me. I meant the total timeout (200ms). Even though there are frames in tx queues after the given timeout for that particular queue, it is quite possible that those frames can be completed successfully by the time we are done with the waiting on the last queue. Vasanth ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] ath9k: make npending frames check as bool 2011-05-09 9:28 ` Vasanthakumar Thiagarajan @ 2011-05-09 9:39 ` Vasanthakumar Thiagarajan 2011-05-09 9:39 ` Mohammed Shafi 1 sibling, 0 replies; 6+ messages in thread From: Vasanthakumar Thiagarajan @ 2011-05-09 9:39 UTC (permalink / raw) To: Vasanth Thiagarajan Cc: Mohammed Shajakhan, linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org On Mon, May 09, 2011 at 02:58:54PM +0530, Vasanth Thiagarajan wrote: > On Mon, May 09, 2011 at 10:00:17AM +0530, Mohammed Shajakhan wrote: > > On Friday 06 May 2011 09:45 PM, Vasanth Thiagarajan wrote: > > > On Fri, May 06, 2011 at 09:24:51PM +0530, Mohammed Shafi Shajakhan wrote: > > >> From: Mohammed Shafi Shajakhan<mshajakhan@atheros.com> > > >> > > >> Signed-off-by: Mohammed Shafi Shajakhan<mshajakhan@atheros.com> > > >> --- > > >> drivers/net/wireless/ath/ath9k/main.c | 7 +++++-- > > >> 1 files changed, 5 insertions(+), 2 deletions(-) > > >> > > >> diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c > > >> index 3de115d..2b78ea2 100644 > > >> --- a/drivers/net/wireless/ath/ath9k/main.c > > >> +++ b/drivers/net/wireless/ath/ath9k/main.c > > >> @@ -2267,7 +2267,7 @@ static void ath9k_flush(struct ieee80211_hw *hw, bool drop) > > >> timeout = 1; > > >> > > >> for (j = 0; j< timeout; j++) { > > >> - int npend = 0; > > >> + bool npend = false; > > >> > > >> if (j) > > >> usleep_range(1000, 2000); > > >> @@ -2276,7 +2276,10 @@ static void ath9k_flush(struct ieee80211_hw *hw, bool drop) > > >> if (!ATH_TXQ_SETUP(sc, i)) > > >> continue; > > >> > > >> - npend += ath9k_has_pending_frames(sc,&sc->tx.txq[i]); > > >> + npend = ath9k_has_pending_frames(sc,&sc->tx.txq[i]); > > >> + > > >> + if (npend) > > >> + break; > > > > > > We need not bail out as soon as there is a pending frame in a queue. > > > There is a possibility that it could be transmitted successfully by > > > the time the given timeout expires. > > > > Hi Vasanth, > > the timeout is before we enter into the loop for checking pending > > frames, so I thought it won't be affecting it. am I missing something? > > please tell me. > > I meant the total timeout (200ms). Even though there are frames in > tx queues after the given timeout for that particular queue, it is > quite possible that those frames can be completed successfully by > the time we are done with the waiting on the last queue. Never mind, I misread your change. Vasanth ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] ath9k: make npending frames check as bool 2011-05-09 9:28 ` Vasanthakumar Thiagarajan 2011-05-09 9:39 ` Vasanthakumar Thiagarajan @ 2011-05-09 9:39 ` Mohammed Shafi 1 sibling, 0 replies; 6+ messages in thread From: Mohammed Shafi @ 2011-05-09 9:39 UTC (permalink / raw) To: Vasanth Thiagarajan Cc: Mohammed Shajakhan, linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org On Monday 09 May 2011 02:58 PM, Vasanth Thiagarajan wrote: > On Mon, May 09, 2011 at 10:00:17AM +0530, Mohammed Shajakhan wrote: >> On Friday 06 May 2011 09:45 PM, Vasanth Thiagarajan wrote: >>> On Fri, May 06, 2011 at 09:24:51PM +0530, Mohammed Shafi Shajakhan wrote: >>>> From: Mohammed Shafi Shajakhan<mshajakhan@atheros.com> >>>> >>>> Signed-off-by: Mohammed Shafi Shajakhan<mshajakhan@atheros.com> >>>> --- >>>> drivers/net/wireless/ath/ath9k/main.c | 7 +++++-- >>>> 1 files changed, 5 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c >>>> index 3de115d..2b78ea2 100644 >>>> --- a/drivers/net/wireless/ath/ath9k/main.c >>>> +++ b/drivers/net/wireless/ath/ath9k/main.c >>>> @@ -2267,7 +2267,7 @@ static void ath9k_flush(struct ieee80211_hw *hw, bool drop) >>>> timeout = 1; >>>> >>>> for (j = 0; j< timeout; j++) { >>>> - int npend = 0; >>>> + bool npend = false; >>>> >>>> if (j) >>>> usleep_range(1000, 2000); >>>> @@ -2276,7 +2276,10 @@ static void ath9k_flush(struct ieee80211_hw *hw, bool drop) >>>> if (!ATH_TXQ_SETUP(sc, i)) >>>> continue; >>>> >>>> - npend += ath9k_has_pending_frames(sc,&sc->tx.txq[i]); >>>> + npend = ath9k_has_pending_frames(sc,&sc->tx.txq[i]); >>>> + >>>> + if (npend) >>>> + break; >>> >>> We need not bail out as soon as there is a pending frame in a queue. >>> There is a possibility that it could be transmitted successfully by >>> the time the given timeout expires. >> >> Hi Vasanth, >> the timeout is before we enter into the loop for checking pending >> frames, so I thought it won't be affecting it. am I missing something? >> please tell me. > > I meant the total timeout (200ms). Even though there are frames in > tx queues after the given timeout for that particular queue, it is > quite possible that those frames can be completed successfully by > the time we are done with the waiting on the last queue. Ok Vasanth. thanks, shafi > > > Vasanth > . > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-05-09 9:39 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-05-06 15:54 [RFC] ath9k: make npending frames check as bool Mohammed Shafi Shajakhan 2011-05-06 16:15 ` Vasanthakumar Thiagarajan 2011-05-09 4:30 ` Mohammed Shafi 2011-05-09 9:28 ` Vasanthakumar Thiagarajan 2011-05-09 9:39 ` Vasanthakumar Thiagarajan 2011-05-09 9:39 ` Mohammed Shafi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).