From: "John W. Linville" <linville@tuxdriver.com>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath5k: Fix lockup due to un-init spinlock.
Date: Tue, 10 May 2011 15:42:11 -0400 [thread overview]
Message-ID: <20110510194211.GG2520@tuxdriver.com> (raw)
In-Reply-To: <1304720674-27031-1-git-send-email-greearb@candelatech.com>
When applied to wireless-2.6, I get this:
CC [M] drivers/net/wireless/ath/ath5k/base.o
drivers/net/wireless/ath/ath5k/base.c: In function ‘ath5k_init_softc’:
drivers/net/wireless/ath/ath5k/base.c:2357:2: error: ‘struct ath5k_softc’ has no member named ‘irqlock’
drivers/net/wireless/ath/ath5k/base.c:2357:2: error: ‘struct ath5k_softc’ has no member named ‘irqlock’
Is this only for -next?
On Fri, May 06, 2011 at 03:24:34PM -0700, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> This was introduced in 2.6.39-rc1 it seems.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
> :100644 100644 203243b... 2204762... M drivers/net/wireless/ath/ath5k/base.c
> drivers/net/wireless/ath/ath5k/base.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
> index 203243b..2204762 100644
> --- a/drivers/net/wireless/ath/ath5k/base.c
> +++ b/drivers/net/wireless/ath/ath5k/base.c
> @@ -2394,7 +2394,7 @@ ath5k_init_softc(struct ath5k_softc *sc, const struct ath_bus_ops *bus_ops)
> spin_lock_init(&sc->rxbuflock);
> spin_lock_init(&sc->txbuflock);
> spin_lock_init(&sc->block);
> -
> + spin_lock_init(&sc->irqlock);
>
> /* Setup interrupt handler */
> ret = request_irq(sc->irq, ath5k_intr, IRQF_SHARED, "ath", sc);
> --
> 1.7.3.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-05-10 19:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 22:24 [PATCH] ath5k: Fix lockup due to un-init spinlock greearb
2011-05-10 19:42 ` John W. Linville [this message]
2011-05-10 19:53 ` Ben Greear
2011-05-10 19:48 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110510194211.GG2520@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).