Re: [PATCH v2] ath6kl: iw dev wlan0 link implementation

[Greg KH <gregkh@suse.de>]

On Wed, May 11, 2011 at 05:02:57AM +0300, Kalle Valo wrote:
> From: Naveen Singh <nsingh@atheros.com>
> 
> implementing the cfg ops that gets called when iw dev wlan0
> link is issued by user. The ops that needs to be implemented
> is get_station.
> 
> kvalo: check the mac address, remove signal_pending() and fix style issues
> 
> Signed-off-by: Naveen Singh <nsingh@atheros.com>
> Signed-off-by: Kalle Valo <kalle.valo@atheros.com>
> ---
>  drivers/staging/ath6kl/os/linux/cfg80211.c |  128 ++++++++++++++++++++++++++++
>  1 files changed, 128 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/ath6kl/os/linux/cfg80211.c b/drivers/staging/ath6kl/os/linux/cfg80211.c
> index efd4ae5..3a89e33 100644
> --- a/drivers/staging/ath6kl/os/linux/cfg80211.c
> +++ b/drivers/staging/ath6kl/os/linux/cfg80211.c
> @@ -1460,6 +1460,133 @@ u32 cipher_suites[] = {
>      WLAN_CIPHER_SUITE_CCMP,
>  };
>  
> +bool is_rate_legacy(s32 rate)
> +{
> +	static const s32 legacy[] = { 1000, 2000, 5500, 11000,
> +				      6000, 9000, 12000, 18000, 24000,
> +				      36000, 48000, 54000 };
> +	u8 i;
> +
> +	for (i = 0; i < 12; i++) {

Please use ARRAY_SIZE for this, and your other loop variables to ensure
that you got it right.

thanks,

greg k-h