From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Rajkumar Manoharan <rmanoharan@atheros.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Rajkumar Manoharan <Rajkumar.Manoharan@atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: cancel scan_work in ieee80211_unregister_hw
Date: Fri, 13 May 2011 12:53:59 +0200 [thread overview]
Message-ID: <20110513105359.GC2206@redhat.com> (raw)
In-Reply-To: <20110513053533.GA20459@vmraj-lnx.users.atheros.com>
On Fri, May 13, 2011 at 11:05:34AM +0530, Rajkumar Manoharan wrote:
> On Thu, May 12, 2011 at 10:55:21PM +0530, Johannes Berg wrote:
> > On Thu, 2011-05-12 at 22:39 +0530, Rajkumar Manoharan wrote:
> > > scan_work is never stopped if the device was unplugged during
> > > s/w scan.
> >
> > How did you come to that conclusion? ieee80211_do_stop() does stop the
> > scan.
> >
> True. But Sometimes ieee80211_scan_cancel is waiting for mutex where
> the lock was already aquired by scan work and scan_work never releases
> the lock till scan completion whenever next_delay == 0.
> This scenario was observed while unplug the card during scan.
So that looks like a bug somwhere in ieee80211_scan_state_* functions,
which should be fixed there, no?
Stanislaw
next prev parent reply other threads:[~2011-05-13 10:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 17:09 [PATCH] mac80211: cancel scan_work in ieee80211_unregister_hw Rajkumar Manoharan
2011-05-12 17:25 ` Johannes Berg
2011-05-13 5:35 ` Rajkumar Manoharan
2011-05-13 10:53 ` Stanislaw Gruszka [this message]
2011-05-13 15:43 ` Johannes Berg
2011-05-13 17:18 ` Rajkumar Manoharan
2011-05-13 17:39 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110513105359.GC2206@redhat.com \
--to=sgruszka@redhat.com \
--cc=Rajkumar.Manoharan@atheros.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rmanoharan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).