From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:38856 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754509Ab1EMNpz (ORCPT ); Fri, 13 May 2011 09:45:55 -0400 Date: Fri, 13 May 2011 09:33:45 -0400 From: "John W. Linville" To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: linux-wireless@vger.kernel.org, Randy Dunlap Subject: Re: [PATCH] ssb: fix pcicore build breakage Message-ID: <20110513133345.GA10555@tuxdriver.com> (sfid-20110513_154558_787822_E89BBDF9) References: <20110512161914.e16be4d3.randy.dunlap@oracle.com> <1305293189-20605-1-git-send-email-linville@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, May 13, 2011 at 03:33:03PM +0200, Rafał Miłecki wrote: > 2011/5/13 John W. Linville : > > drivers/ssb/main.c:1336: error: 'SSB_PCICORE_BCAST_ADDR' undeclared (first use in this function) > > drivers/ssb/main.c:1337: error: 'SSB_PCICORE_BCAST_DATA' undeclared (first use in this function) > > drivers/ssb/main.c:1349: error: 'struct ssb_pcicore' has no member named 'dev' > > > > Reported-by: Randy Dunlap > > Signed-off-by: John W. Linville > > --- > >  drivers/ssb/main.c |    2 ++ > >  1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c > > index ee2937c..a53fc4d 100644 > > --- a/drivers/ssb/main.c > > +++ b/drivers/ssb/main.c > > @@ -1332,6 +1332,7 @@ EXPORT_SYMBOL(ssb_bus_powerup); > >  static void ssb_broadcast_value(struct ssb_device *dev, > >                                u32 address, u32 data) > >  { > > +#ifdef CONFIG_SSB_DRIVER_PCICORE > >        /* This is used for both, PCI and ChipCommon core, so be careful. */ > >        BUILD_BUG_ON(SSB_PCICORE_BCAST_ADDR != SSB_CHIPCO_BCAST_ADDR); > >        BUILD_BUG_ON(SSB_PCICORE_BCAST_DATA != SSB_CHIPCO_BCAST_DATA); > > @@ -1340,6 +1341,7 @@ static void ssb_broadcast_value(struct ssb_device *dev, > >        ssb_read32(dev, SSB_PCICORE_BCAST_ADDR); /* flush */ > >        ssb_write32(dev, SSB_PCICORE_BCAST_DATA, data); > >        ssb_read32(dev, SSB_PCICORE_BCAST_DATA); /* flush */ > > +#endif > >  } > > > >  void ssb_commit_settings(struct ssb_bus *bus) > > From *quick* review I think it's wrong. WIth this patch we don't do > commiting without PCI driver. This is still possible, we just need to > use ChipCommon for commiting. I'm happy for a better patch, but since the build is failing as-is... -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.