[PATCH 1/1] netlink: nla_nest_end return "unsigned init"

[PATCH 1/1] netlink: nla_nest_end return "unsigned init"

[Wey-Yi Guy]

skb->len has unsigned int, return the correct value from nla_nest_end call.

Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
---
 include/net/netlink.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/include/net/netlink.h b/include/net/netlink.h
index 8a3906a..241fc0d 100644
--- a/include/net/netlink.h
+++ b/include/net/netlink.h
@@ -1015,7 +1015,8 @@ static inline struct nlattr *nla_nest_start(struct sk_buff *skb, int attrtype)
  *
  * Returns the total data length of the skb.
  */
-static inline int nla_nest_end(struct sk_buff *skb, struct nlattr *start)
+static inline unsigned int nla_nest_end(struct sk_buff *skb,
+					struct nlattr *start)
 {
 	start->nla_len = skb_tail_pointer(skb) - (unsigned char *)start;
 	return skb->len;
-- 
1.7.0.4

Re: [PATCH 1/1] netlink: nla_nest_end return "unsigned init"

[John W. Linville]

This should go to netdev@vger.kernel.org instead...

On Mon, May 16, 2011 at 07:23:30AM -0700, Wey-Yi Guy wrote:
> skb->len has unsigned int, return the correct value from nla_nest_end call.
> 
> Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> ---
>  include/net/netlink.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/include/net/netlink.h b/include/net/netlink.h
> index 8a3906a..241fc0d 100644
> --- a/include/net/netlink.h
> +++ b/include/net/netlink.h
> @@ -1015,7 +1015,8 @@ static inline struct nlattr *nla_nest_start(struct sk_buff *skb, int attrtype)
>   *
>   * Returns the total data length of the skb.
>   */
> -static inline int nla_nest_end(struct sk_buff *skb, struct nlattr *start)
> +static inline unsigned int nla_nest_end(struct sk_buff *skb,
> +					struct nlattr *start)
>  {
>  	start->nla_len = skb_tail_pointer(skb) - (unsigned char *)start;
>  	return skb->len;
> -- 
> 1.7.0.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [PATCH 1/1] netlink: nla_nest_end return "unsigned init"

[David Miller]

From: "John W. Linville" <linville@tuxdriver.com>
Date: Mon, 16 May 2011 13:35:48 -0400

> This should go to netdev@vger.kernel.org instead...
> 
> On Mon, May 16, 2011 at 07:23:30AM -0700, Wey-Yi Guy wrote:
>> skb->len has unsigned int, return the correct value from nla_nest_end call.
>> 
>> Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>

Plus, the only users of the return value use it to feed "int"
return values of functions.  F.e. net/core/neighbour.c's use
in neightbl_fill_parms().

I don't see this as being any better or worse, and we should
just leave the return value alone.