From: "John W. Linville" <linville@tuxdriver.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Felix Fietkau <nbd@openwrt.org>,
linux-wireless@vger.kernel.org, lrodriguez@atheros.com
Subject: Re: [PATCH 1/2] ath9k: unify edma and non-edma tx code, improve tx fifo handling
Date: Thu, 19 May 2011 10:18:58 -0400 [thread overview]
Message-ID: <20110519141858.GD2575@tuxdriver.com> (raw)
In-Reply-To: <4DD52555.8020300@lwfinger.net>
On Thu, May 19, 2011 at 09:12:37AM -0500, Larry Finger wrote:
> On 05/19/2011 04:00 AM, Felix Fietkau wrote:
> >On 2011-05-18 9:07 PM, John W. Linville wrote:
> >>CC [M] drivers/net/wireless/ath/ath9k/xmit.o
> >>drivers/net/wireless/ath/ath9k/xmit.c: In function ‘ath_tx_edma_tasklet’:
> >>drivers/net/wireless/ath/ath9k/xmit.c:2199:18: warning: ‘txq’ may be used
> >>uninitialized in this function
> >>
> >>Please don't add warnings, especially not valid ones... :-)
> >Odd, I wonder why my compiler didn't show me this warning when I worked on the
> >patch, need to check my CFLAGS :)
>
> If you figure out the CFLAGS needed to show the warnings, please
> share that information with the list.
There really is an issue here -- it's like the gcc folks have added a
randomize function to change the warnings generated between different
versions (or even different compiles of the same version) of their
compiler...
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2011-05-19 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 11:59 [PATCH 1/2] ath9k: unify edma and non-edma tx code, improve tx fifo handling Felix Fietkau
2011-05-18 11:59 ` [PATCH 2/2] ath9k_hw: remove ath9k_hw_get_desc_link Felix Fietkau
2011-05-18 19:07 ` [PATCH 1/2] ath9k: unify edma and non-edma tx code, improve tx fifo handling John W. Linville
2011-05-19 9:00 ` Felix Fietkau
2011-05-19 14:12 ` Larry Finger
2011-05-19 14:18 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519141858.GD2575@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).