From: Ido Yariv <ido@wizery.com>
To: Kalle Valo <kvalo@adurom.com>
Cc: Luciano Coelho <coelho@ti.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/3] wl12xx: Support routing FW logs to the host
Date: Mon, 6 Jun 2011 23:06:01 +0300 [thread overview]
Message-ID: <20110606200601.GK31554@WorkStation> (raw)
In-Reply-To: <87aadv864m.fsf@purkki.adurom.net>
On Mon, Jun 06, 2011 at 04:02:49PM +0300, Kalle Valo wrote:
> Ido Yariv <ido@wizery.com> writes:
> > A sysfs binary file named "fwlog" was added to support this feature,
> > letting a monitor process read the FW messages. The log is transferred
> > from the FW only when available, so the reading process might block.
>
> Using a sysfs file sounds ugly, isn't there a better way to do this?
> For example, does ftrace&co provide anything which wireless drivers
> could use?
A sysfs entry is indeed sub-optimal. However, we had two requirements
for this feature:
1. Retrieving logs should be simple and require no non-standard usermode
applications.
2. The on-demand mode could be used on production platforms.
ftrace/debugfs/etc. might not be enabled on such systems.
For now, we chose to stick with a single sysfs entry, as it accomplishes
the above. I agree it looks a bit odd though.
Ido.
next prev parent reply other threads:[~2011-06-06 20:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 11:57 [PATCH 1/3] wl12xx: Check for FW quirks as soon as the FW boots Ido Yariv
2011-06-06 11:57 ` [PATCH 2/3] wl12xx: Avoid recovery while one is already in progress Ido Yariv
2011-06-06 11:57 ` [PATCH 3/3] wl12xx: Support routing FW logs to the host Ido Yariv
2011-06-06 13:02 ` Kalle Valo
2011-06-06 20:06 ` Ido Yariv [this message]
2011-06-09 13:49 ` Kalle Valo
2011-06-27 12:43 ` [PATCH 1/3] wl12xx: Check for FW quirks as soon as the FW boots Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606200601.GK31554@WorkStation \
--to=ido@wizery.com \
--cc=coelho@ti.com \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).