From: "John W. Linville" <linville@tuxdriver.com>
To: "Manoharan, Rajkumar" <rmanohar@qca.qualcomm.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 6/6] mac80211: stop queues before rate control updation
Date: Tue, 7 Jun 2011 14:05:53 -0400 [thread overview]
Message-ID: <20110607180552.GF9320@tuxdriver.com> (raw)
In-Reply-To: <8F3AF1C9F856774F8C8D67AA7EDFEC88012CE709@nasanexd02d.na.qualcomm.com>
On Tue, Jun 07, 2011 at 08:39:57AM +0000, Manoharan, Rajkumar wrote:
> > > On Mon, 2011-06-06 at 14:44 -0400, John W. Linville wrote:
> >
> > > > During the channel type change, the pending tx frames in hw queues are dropped by hw config.
> > > > But before updating rate control, the packets can be queued again with older HT rates.
> > > > This contradicts with hw config mode and sometimes is causing baseband issues. This issue
> > > > was observed only on flooding uplink traffic. To ensure that the frames are always xmitted with
> > > > updated rates, the queues are stopped before hw config and waken up after rc updation.
> >>
> > > Johannes, do you find this explanation satisfactory (perhaps with
> > > some new queue stop reason definition)?
> >
> > No, it doesn't address the fact that any packet that is pending will
> > still be processed -- as I said before, the stop doesn't include a
> > flush.
>
> Yes. I agree. Without flushing, still the packets can choose wrong rates. I missed that.
> But I assumed that it would be better to stop queues before rc update. Thus we can avoid revisiting
> the queued frames chosen with older (this case ht40) rate after rc changes. And fixing at mac80211 would help
> to other rate controls too.
OK, it seems like this isn't getting resolved quickly. I'm going to
revert it for now, and hope for a more widely acceptable solution soon.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-06-07 18:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 12:22 [PATCH 1/6] ath9k: Reset chip on baseband hang Rajkumar Manoharan
2011-05-20 12:22 ` [PATCH 3/6] ath9k: Handle IBSS status changes in BSS_CHANGED_IBSS Rajkumar Manoharan
2011-05-20 12:22 ` [PATCH 4/6] ath9k_hw: disable phy restart on baseband panic caused by RXSM Rajkumar Manoharan
2011-05-20 12:22 ` [PATCH 5/6] ath9k: set 40 Mhz rate only if hw is configured in ht40 Rajkumar Manoharan
2011-05-20 12:22 ` [PATCH 6/6] mac80211: stop queues before rate control updation Rajkumar Manoharan
2011-05-31 6:35 ` Johannes Berg
2011-05-31 7:20 ` Adrian Chadd
2011-06-01 18:58 ` John W. Linville
2011-06-03 5:00 ` Manoharan, Rajkumar
2011-06-06 18:44 ` John W. Linville
2011-06-06 18:57 ` Johannes Berg
2011-06-07 8:39 ` Manoharan, Rajkumar
2011-06-07 18:05 ` John W. Linville [this message]
[not found] ` <1305894135-14036-2-git-send-email-rmanoharan@atheros.com>
2011-05-21 4:27 ` [PATCH 2/6] ath9k: Remove ATH9K_BEACON_PERIOD mask Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110607180552.GF9320@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).