From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Mohammed Shafi <shafi.wireless@gmail.com>
Cc: Adrian Chadd <adrian@freebsd.org>,
Jonathan Nieder <jrnieder@gmail.com>,
ath9k-devel@venema.h4ckr.net, Tony Houghton <h@realh.co.uk>,
linux-wireless <linux-wireless@vger.kernel.org>,
camilo@mesias.co.uk, Rajkumar Manoharan <rmanoharan@atheros.com>
Subject: Re: APSM, AR9285 and bus hangs
Date: Tue, 14 Jun 2011 12:09:19 +0200 [thread overview]
Message-ID: <20110614100918.GA4450@redhat.com> (raw)
In-Reply-To: <BANLkTi=eKBcV5OjP0qqLe6n9GsiwhYLejg@mail.gmail.com>
On Mon, Jun 13, 2011 at 07:10:56PM +0530, Mohammed Shafi wrote:
> > I see this commit in 2.6.39, missed in 2.6.38 and 2.6.35 currently.
> > Is possible this is the fix which do not break other things?
>
> hi,
> no, this fix only affects AR9280 and it does not affects AR9285.
That could be another stupid question, but could we do not touch
these bits on older AR9285s and disable them only on revision, that
was added by bad commit 53bc7aa08b48e5cd745f986731cc7dc24eef2a9f
diff --git a/drivers/net/wireless/ath/ath9k/ar9002_hw.c b/drivers/net/wireless/ath/ath9k/ar9002_hw.c
index f344cc2..91d99eb 100644
--- a/drivers/net/wireless/ath/ath9k/ar9002_hw.c
+++ b/drivers/net/wireless/ath/ath9k/ar9002_hw.c
@@ -384,7 +384,7 @@ static void ar9002_hw_configpcipowersave(struct ath_hw *ah,
}
}
- if (AR_SREV_9280(ah) || AR_SREV_9285(ah) || AR_SREV_9287(ah)) {
+ if (AR_SREV_9280(ah) || AR_SREV_9285E_20(ah) || AR_SREV_9287(ah)) {
/*
* Disable bit 6 and 7 before entering D3 to
* prevent system hang.
next prev parent reply other threads:[~2011-06-14 10:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 13:01 APSM, AR9285 and bus hangs Adrian Chadd
2011-06-13 13:09 ` Camilo Mesias
2011-06-13 13:20 ` Stanislaw Gruszka
2011-06-13 13:40 ` Mohammed Shafi
2011-06-14 10:09 ` Stanislaw Gruszka [this message]
2011-06-14 11:44 ` Mohammed Shafi
2011-06-14 11:47 ` Adrian Chadd
2011-06-14 18:47 ` Tony Houghton
2011-06-14 0:02 ` Adrian Chadd
2011-07-15 16:18 ` Stanislaw Gruszka
2011-07-22 13:30 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110614100918.GA4450@redhat.com \
--to=sgruszka@redhat.com \
--cc=adrian@freebsd.org \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=camilo@mesias.co.uk \
--cc=h@realh.co.uk \
--cc=jrnieder@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanoharan@atheros.com \
--cc=shafi.wireless@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).