* Re: [stable] Please revert "iwlagn: Support new 5000 microcode." from 2.6.32 and 2.6.33 [not found] ` <20110614230344.GA2065@kroah.com> @ 2011-06-15 1:14 ` Herton Ronaldo Krzesinski 2011-06-15 5:57 ` Stanislaw Gruszka 0 siblings, 1 reply; 2+ messages in thread From: Herton Ronaldo Krzesinski @ 2011-06-15 1:14 UTC (permalink / raw) To: Greg KH Cc: stable, donald.h.fry, reinette.chatre, wey-yi.w.guy, ilw, linville, sgruszka, ak, linux-wireless, netdev, linux-kernel On Tue, Jun 14, 2011 at 04:03:44PM -0700, Greg KH wrote: > On Mon, Jun 13, 2011 at 03:13:18PM -0300, Herton Ronaldo Krzesinski wrote: > > The patch ("iwlagn: Support new 5000 microcode") shoudn't have been > > applied on 2.6.32 and 2.6.33 stable trees, it doesn't support new > > firmware file format, thus if the new firmware is on the disk, loading > > fails, as reported on: > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/796336 > > > > Support for the iwlagn new firmware file format was only added beginning > > with 2.6.35 (commit "iwlagn: implement loading a new firmware file > > type"), so iwlagn works with new firmware only with 2.6.35 or later. > > Can I get an ack from the developer of the patch and the people involved > with it first? It was asked to be backported for a reason, so I would > at least like to get the people who asked for the backport to have a > chance to respond please. > > It's only nice, why would you exclude them? I didn't intend to exclude anyone and I'm just reporting it, it didn't came to my mind CC'ing people while sending to stable, and hopefully everyone related are CC'ed now. Also note that this revert request is for 2.6.32 and 2.6.33 *only* And seems the right thing to do for them. The other stable release where this was applied (2.6.35) looks fine but these two are too old to support the new firmware (don't work, need extra patches backported which weren't, like the commit I mentioned -- commit "iwlagn: implement loading a new firmware file type"), as yourself can check reading the code/bug report, and what I wrote. > > greg k-h > -- []'s Herton ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [stable] Please revert "iwlagn: Support new 5000 microcode." from 2.6.32 and 2.6.33 2011-06-15 1:14 ` [stable] Please revert "iwlagn: Support new 5000 microcode." from 2.6.32 and 2.6.33 Herton Ronaldo Krzesinski @ 2011-06-15 5:57 ` Stanislaw Gruszka 0 siblings, 0 replies; 2+ messages in thread From: Stanislaw Gruszka @ 2011-06-15 5:57 UTC (permalink / raw) To: Herton Ronaldo Krzesinski Cc: Greg KH, stable, donald.h.fry, reinette.chatre, wey-yi.w.guy, ilw, linville, ak, linux-wireless, netdev, linux-kernel On Tue, Jun 14, 2011 at 10:14:44PM -0300, Herton Ronaldo Krzesinski wrote: > On Tue, Jun 14, 2011 at 04:03:44PM -0700, Greg KH wrote: > > On Mon, Jun 13, 2011 at 03:13:18PM -0300, Herton Ronaldo Krzesinski wrote: > > > The patch ("iwlagn: Support new 5000 microcode") shoudn't have been > > > applied on 2.6.32 and 2.6.33 stable trees, it doesn't support new > > > firmware file format, thus if the new firmware is on the disk, loading > > > fails, as reported on: > > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/796336 > > > > > > Support for the iwlagn new firmware file format was only added beginning > > > with 2.6.35 (commit "iwlagn: implement loading a new firmware file > > > type"), so iwlagn works with new firmware only with 2.6.35 or later. > > > > Can I get an ack from the developer of the patch and the people involved > > with it first? It was asked to be backported for a reason, so I would > > at least like to get the people who asked for the backport to have a > > chance to respond please. > > > > It's only nice, why would you exclude them? > > I didn't intend to exclude anyone and I'm just reporting it, it didn't > came to my mind CC'ing people while sending to stable, and hopefully > everyone related are CC'ed now. > > Also note that this revert request is for 2.6.32 and 2.6.33 *only* > > And seems the right thing to do for them. > > The other stable release where this was applied (2.6.35) looks fine > but these two are too old to support the new firmware (don't work, need > extra patches backported which weren't, like the commit I mentioned -- > commit "iwlagn: implement loading a new firmware file type"), as yourself > can check reading the code/bug report, and what I wrote. ACK for revert. I could be wrong, but I think some more patches, except mentioned new format patch, are needed to make driver work reliably with the new firmware. Stanislaw ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-15 5:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20110613181317.GA3385@herton-IdeaPad-Y430>
[not found] ` <20110614230344.GA2065@kroah.com>
2011-06-15 1:14 ` [stable] Please revert "iwlagn: Support new 5000 microcode." from 2.6.32 and 2.6.33 Herton Ronaldo Krzesinski
2011-06-15 5:57 ` Stanislaw Gruszka
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).