Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Michael Büsch" <m@bues.ch>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
	mb@bu3sch.de, linville@tuxdriver.com,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ssb: fix ssb clock rate according to broadcom source
Date: Wed, 22 Jun 2011 07:02:12 +0000	[thread overview]
Message-ID: <20110622070212.076777c0@Nokia-N900> (raw)
In-Reply-To: <4E010EE6.9060605@lwfinger.net>

On Tue, 21 Jun 2011 16:36:38 -0500
Larry Finger <Larry.Finger@lwfinger.net> wrote:

> On 06/21/2011 01:53 PM, Hauke Mehrtens wrote:
> > This fix was done according to si_clock_rate function in broadcom siutils.c
> >
> > Signed-off-by: Hauke Mehrtens<hauke@hauke-m.de>
> > ---
> >   drivers/ssb/main.c |    4 ++--
> >   1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> > index e568664..57b7b64 100644
> > --- a/drivers/ssb/main.c
> > +++ b/drivers/ssb/main.c
> > @@ -1002,8 +1002,8 @@ u32 ssb_calc_clock_rate(u32 plltype, u32 n, u32 m)
> >   	switch (plltype) {
> >   	case SSB_PLLTYPE_6: /* 100/200 or 120/240 only */
> >   		if (m&  SSB_CHIPCO_CLK_T6_MMASK)
> > -			return SSB_CHIPCO_CLK_T6_M0;
> > -		return SSB_CHIPCO_CLK_T6_M1;
> > +			return SSB_CHIPCO_CLK_T6_M1;
> > +		return SSB_CHIPCO_CLK_T6_M0;
> >   	case SSB_PLLTYPE_1: /* 48Mhz base, 3 dividers */
> >   	case SSB_PLLTYPE_3: /* 25Mhz, 2 dividers */
> >   	case SSB_PLLTYPE_4: /* 48Mhz, 4 dividers */
> 
> This patch sent me looking to find the public source for this routine. After 
> finding it in the source section of Broadcom-wl, I noticed there is some 
> additional code that is not implemented in the ssb version. Should this 
> additional material be implemented, or is it not applicable?

could you quote that function here? That would be way easier to get what were talking about.


  reply	other threads:[~2011-06-22  6:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-21 18:31 [PATCH] ssb: fix ssb clock rate according to broadcom source Hauke Mehrtens
2011-06-21 18:53 ` [PATCH v2] " Hauke Mehrtens
2011-06-21 21:36   ` Larry Finger
2011-06-22  7:02     ` Michael Büsch [this message]
2011-06-22 22:06       ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110622070212.076777c0@Nokia-N900 \
    --to=m@bues.ch \
    --cc=Larry.Finger@lwfinger.net \
    --cc=hauke@hauke-m.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox