From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
sameo@linux.intel.com, lauro.venancio@openbossa.org,
marcio.macedo@openbossa.org, Waldemar.Rymarkiewicz@tieto.com
Subject: Re: [RFC][PATCH v2 3/7] NFC: add nfc generic netlink interface
Date: Wed, 22 Jun 2011 16:55:48 -0300 [thread overview]
Message-ID: <20110622195548.GB2583@joana> (raw)
In-Reply-To: <1308725771.3883.0.camel@jlt3.sipsolutions.net>
Hi Johannes,
* Johannes Berg <johannes@sipsolutions.net> [2011-06-22 08:56:11 +0200]:
> On Tue, 2011-06-21 at 19:05 -0300, Gustavo F. Padovan wrote:
>
> > > static int __init nfc_init(void)
> > > {
> > > + int rc;
> > > +
> > > printk(KERN_INFO "NFC Core ver %s\n", VERSION);
> > >
> > > - return class_register(&nfc_class);
> > > + rc = class_register(&nfc_class);
> > > + if (rc)
> > > + goto err;
> >
> > Just return rc here and get rid of the label.
>
>
> Seriously, please trim your quotes. If you're commenting on a specific
> piece of code, you can well remove all the code you're not commenting on
> like I did above.
Sorry, I didn't realize that it was so big. Also I usually forget to trim the
beginning of the patch. Have to get used to that.
Gustavo
next prev parent reply other threads:[~2011-06-22 19:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 17:50 [RFC][PATCH v2 0/7] NFC subsystem Aloisio Almeida Jr
2011-06-20 17:50 ` [RFC][PATCH v2 1/7] netlink: advertise incomplete dumps Aloisio Almeida Jr
2011-06-20 17:50 ` [RFC][PATCH v2 2/7] NFC: add nfc subsystem core Aloisio Almeida Jr
2011-06-21 21:55 ` Gustavo F. Padovan
2011-06-22 2:24 ` Marcel Holtmann
2011-06-22 14:18 ` Aloisio Almeida
2011-06-20 17:50 ` [RFC][PATCH v2 3/7] NFC: add nfc generic netlink interface Aloisio Almeida Jr
2011-06-21 22:05 ` Gustavo F. Padovan
2011-06-21 22:15 ` Eliad Peller
2011-06-22 20:03 ` Gustavo F. Padovan
2011-06-22 6:56 ` Johannes Berg
2011-06-22 19:55 ` Gustavo F. Padovan [this message]
2011-06-22 14:07 ` Aloisio Almeida
2011-06-22 7:34 ` Johannes Berg
2011-06-22 12:57 ` Samuel Ortiz
2011-06-22 13:08 ` Johannes Berg
2011-06-22 13:27 ` Samuel Ortiz
2011-06-22 16:49 ` Aloisio Almeida
2011-06-23 7:55 ` Johannes Berg
2011-06-20 17:50 ` [RFC][PATCH v2 4/7] NFC: add NFC socket family Aloisio Almeida Jr
2011-06-20 17:50 ` [RFC][PATCH v2 5/7] NFC: add the NFC socket raw protocol Aloisio Almeida Jr
2011-06-20 17:50 ` [RFC][PATCH v2 6/7] NFC: pn533: add NXP pn533 nfc device driver Aloisio Almeida Jr
2011-06-20 17:50 ` [RFC][PATCH v2 7/7] NFC: add Documentation/networking/nfc.txt Aloisio Almeida Jr
2011-06-20 20:24 ` [RFC][PATCH v3 " Aloisio Almeida Jr
2011-06-21 21:23 ` Randy Dunlap
2011-06-22 14:13 ` Aloisio Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110622195548.GB2583@joana \
--to=padovan@profusion.mobi \
--cc=Waldemar.Rymarkiewicz@tieto.com \
--cc=aloisio.almeida@openbossa.org \
--cc=johannes@sipsolutions.net \
--cc=lauro.venancio@openbossa.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=marcio.macedo@openbossa.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).