Re: [RFC v3 11/13] bcm47xx: make it possible to build bcm47xx without ssb.

[Florian Fainelli <florian@openwrt.org>]

Hello Hauke,

On Thursday 30 June 2011 00:11:56 Hauke Mehrtens wrote:
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
>  arch/mips/Kconfig                            |    8 +-------
>  arch/mips/bcm47xx/Kconfig                    |   18 ++++++++++++++++++
>  arch/mips/bcm47xx/Makefile                   |    3 ++-
>  arch/mips/bcm47xx/gpio.c                     |    6 ++++++
>  arch/mips/bcm47xx/nvram.c                    |    4 ++++
>  arch/mips/bcm47xx/serial.c                   |    4 ++++
>  arch/mips/bcm47xx/setup.c                    |    8 ++++++++
>  arch/mips/bcm47xx/time.c                     |    2 ++
>  arch/mips/include/asm/mach-bcm47xx/bcm47xx.h |    4 ++++
>  arch/mips/include/asm/mach-bcm47xx/gpio.h    |   12 ++++++++++++
>  arch/mips/pci/pci-bcm47xx.c                  |    6 ++++++
>  drivers/watchdog/bcm47xx_wdt.c               |    4 ++++
>  12 files changed, 71 insertions(+), 8 deletions(-)
>  create mode 100644 arch/mips/bcm47xx/Kconfig
> 
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 45f7aac..dcb3675 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -91,15 +91,8 @@ config BCM47XX
>  	select DMA_NONCOHERENT
>  	select HW_HAS_PCI
>  	select IRQ_CPU
> -	select SYS_HAS_CPU_MIPS32_R1
>  	select SYS_SUPPORTS_32BIT_KERNEL
>  	select SYS_SUPPORTS_LITTLE_ENDIAN
> -	select SSB
> -	select SSB_DRIVER_MIPS
> -	select SSB_DRIVER_EXTIF
> -	select SSB_EMBEDDED
> -	select SSB_B43_PCI_BRIDGE if PCI
> -	select SSB_PCICORE_HOSTMODE if PCI
>  	select GENERIC_GPIO
>  	select SYS_HAS_EARLY_PRINTK
>  	select CFE
> @@ -788,6 +781,7 @@ endchoice
> 
>  source "arch/mips/alchemy/Kconfig"
>  source "arch/mips/ath79/Kconfig"
> +source "arch/mips/bcm47xx/Kconfig"
>  source "arch/mips/bcm63xx/Kconfig"
>  source "arch/mips/jazz/Kconfig"
>  source "arch/mips/jz4740/Kconfig"
> diff --git a/arch/mips/bcm47xx/Kconfig b/arch/mips/bcm47xx/Kconfig
> new file mode 100644
> index 0000000..443d918
> --- /dev/null
> +++ b/arch/mips/bcm47xx/Kconfig
> @@ -0,0 +1,18 @@
> +if BCM47XX
> +
> +config BCM47XX_SSB
> +	bool "BCMA Support for Broadcom BCM47XX"

Should not this be:
"SSB support for Broadcom BCM47XX"?

> +	select SYS_HAS_CPU_MIPS32_R1
> +	select SSB
> +	select SSB_DRIVER_MIPS
> +	select SSB_DRIVER_EXTIF
> +	select SSB_EMBEDDED
> +	select SSB_B43_PCI_BRIDGE if PCI
> +	select SSB_PCICORE_HOSTMODE if PCI
> +	default y
> +	help
> +	 Add support for old Broadcom BCM47xx boards with Sonics Silicon
> Backplane support bus. +
> +	 This will generate an image with support for SSB and MIPS32 R2
> instruction set. +
> +endif
> diff --git a/arch/mips/bcm47xx/Makefile b/arch/mips/bcm47xx/Makefile
> index 7465e8a..4add173 100644
> --- a/arch/mips/bcm47xx/Makefile
> +++ b/arch/mips/bcm47xx/Makefile
> @@ -3,4 +3,5 @@
>  # under Linux.
>  #