From: "John W. Linville" <linville@tuxdriver.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ipw2100: Fix command list for debugging
Date: Tue, 5 Jul 2011 14:08:32 -0400 [thread overview]
Message-ID: <20110705180832.GA7540@tuxdriver.com> (raw)
In-Reply-To: <20110704145346.384a462a@endymion.delvare>
On Mon, Jul 04, 2011 at 02:53:46PM +0200, Jean Delvare wrote:
> A missing comma in the array causes an off-by-one for later commands.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: "John W. Linville" <linville@tuxdriver.com>
> ---
> Note: I don't have the documentation and I don't have the hardware, so
> an expert should double-check this one.
>
> drivers/net/wireless/ipw2x00/ipw2100.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-3.0-rc5.orig/drivers/net/wireless/ipw2x00/ipw2100.c 2011-05-20 10:42:41.000000000 +0200
> +++ linux-3.0-rc5/drivers/net/wireless/ipw2x00/ipw2100.c 2011-07-04 14:44:22.000000000 +0200
> @@ -287,7 +287,8 @@ static const char *command_types[] = {
> "unused", /* HOST_INTERRUPT_COALESCING */
> "undefined",
> "CARD_DISABLE_PHY_OFF",
> - "MSDU_TX_RATES" "undefined",
> + "MSDU_TX_RATES",
> + "undefined",
> "undefined",
> "SET_STATION_STAT_BITS",
> "CLEAR_STATIONS_STAT_BITS",
This code dates from 2005:
commit ee8e365aa6395e721399127ccf3d28d269136f0e
Author: James Ketrenos <jketreno@linux.intel.com>
Date: Wed Sep 14 09:47:29 2005 -0500
Ran scripts/Lindent on drivers/net/wireless/ipw2{1,2}00.{c,h}
No other changes.
Signed-off-by: James Ketrenos <jketreno@linux.intel.com>
Prior to that, those two strings were on two different lines but with
no comma betwen them -- so effectively the same as now. Changing it
as you suggest would change the offsets in the array of the following
string pointers, which I suspect will break the debugging code that
uses it.
I would rather not take this change. OTOH, perhaps you could submit a
patch that simply remove the second quoted string from the single line?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-07-05 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 12:53 [PATCH] ipw2100: Fix command list for debugging Jean Delvare
2011-07-05 18:08 ` John W. Linville [this message]
2011-07-05 22:22 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110705180832.GA7540@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=khali@linux-fr.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).