From: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
To: Joe Perches <joe@perches.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
<linux-wireless@vger.kernel.org>, <devel@linuxdriverproject.org>,
<gregkh@suse.de>
Subject: Re: [PATCH 11/24] ath6kl: add htc.c
Date: Wed, 13 Jul 2011 19:08:08 +0530 [thread overview]
Message-ID: <20110713133807.GA3424@vasanth-laptop> (raw)
In-Reply-To: <1310560384.1662.11.camel@Joe-Laptop>
On Wed, Jul 13, 2011 at 05:33:04AM -0700, Joe Perches wrote:
> On Wed, 2011-07-13 at 10:46 +0300, Kalle Valo wrote:
> > On 07/13/2011 07:30 AM, Joe Perches wrote:
> > > On Wed, 2011-07-13 at 04:34 +0300, Kalle Valo wrote:
> > >> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
> > >> diff --git a/drivers/net/wireless/ath/ath6kl/htc.c b/drivers/net/wireless/ath/ath6kl/htc.c
> > > []
> > >> +static void htc_tx_comp_update(struct htc_target *target,
> > >> + struct htc_endpoint *endpoint,
> > >> + struct htc_packet *packet)
> > >> +{
> > > []
> > >> ath6kl_dbg(ATH6KL_DBG_HTC_SEND, "ctxt:0x%lx dist:0x%lx\n",
> > >> + (unsigned long) target->cred_dist_cntxt,
> > >> + (unsigned long *) &target->cred_dist_list);
> > > compiler warning?
> > I haven't seen any. But all these unsigned long casts will be removed
> > anyway.
>
> You need to update debug.h [08/24]
>
> > diff --git a/drivers/net/wireless/ath/ath6kl/debug.h b/drivers/net/wireless/ath/ath6kl/debug.h
> []
> > +extern int ath6kl_printk(const char *level, const char *fmt, ...);
>
> You're not seeing compiler warnings for mismatched
> arguments because this should to be:
>
> extern __attribute__((format (printf, 2, 3)))
> int ath6kl_printk(const char *level, const char *fmt, ...);
Right, format attribute exposes quite a few mismatch in format
string, we'll address them in next version. Thanks for pointing this out
Vasanth
next prev parent reply other threads:[~2011-07-13 13:38 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 1:32 [PATCH 00/24] ath6kl cleaned up driver Kalle Valo
2011-07-13 1:33 ` [PATCH 01/24] ath6kl: add bmi.c Kalle Valo
2011-07-13 4:28 ` Joe Perches
2011-07-13 7:08 ` Kalle Valo
2011-07-13 12:19 ` Joe Perches
2011-07-14 6:46 ` Kalle Valo
2011-07-14 7:33 ` Joe Perches
2011-07-14 7:38 ` Kalle Valo
2011-07-13 1:33 ` [PATCH 02/24] ath6kl: add bmi.h Kalle Valo
2011-07-13 1:33 ` [PATCH 03/24] ath6kl: add cfg80211.c Kalle Valo
2011-07-13 4:29 ` Joe Perches
2011-07-13 7:22 ` Kalle Valo
2011-07-13 1:33 ` [PATCH 04/24] ath6kl: add cfg80211.h Kalle Valo
2011-07-13 1:33 ` [PATCH 05/24] ath6kl: add common.h Kalle Valo
2011-07-13 1:33 ` [PATCH 06/24] ath6kl: add core.h Kalle Valo
2011-07-13 4:29 ` Joe Perches
2011-07-13 7:41 ` Kalle Valo
2011-07-13 1:34 ` [PATCH 07/24] ath6kl: add debug.c Kalle Valo
2011-07-13 4:29 ` Joe Perches
2011-07-13 1:34 ` [PATCH 08/24] ath6kl: add debug.h Kalle Valo
2011-07-13 1:34 ` [PATCH 09/24] ath6kl: add hif-ops.h Kalle Valo
2011-07-13 1:34 ` [PATCH 10/24] ath6kl: add hif.h Kalle Valo
2011-07-13 1:34 ` [PATCH 11/24] ath6kl: add htc.c Kalle Valo
2011-07-13 4:30 ` Joe Perches
2011-07-13 7:46 ` Kalle Valo
2011-07-13 12:33 ` Joe Perches
2011-07-13 13:38 ` Vasanthakumar Thiagarajan [this message]
2011-07-13 1:34 ` [PATCH 12/24] ath6kl: add htc.h Kalle Valo
2011-07-13 1:35 ` [PATCH 13/24] ath6kl: add htc_hif.c Kalle Valo
2011-07-13 1:35 ` [PATCH 14/24] ath6kl: add htc_hif.h Kalle Valo
2011-07-13 1:35 ` [PATCH 15/24] ath6kl: add ieee80211.h Kalle Valo
2011-07-13 7:29 ` Johannes Berg
2011-07-13 8:25 ` Kalle Valo
2011-07-13 1:35 ` [PATCH 16/24] ath6kl: add init.c Kalle Valo
2011-07-13 1:35 ` [PATCH 17/24] ath6kl: add main.c Kalle Valo
2011-07-13 4:30 ` Joe Perches
2011-07-13 8:18 ` Kalle Valo
2011-07-13 1:35 ` [PATCH 18/24] ath6kl: add node.c Kalle Valo
2011-07-13 1:36 ` [PATCH 19/24] ath6kl: add sdio.c Kalle Valo
2011-07-13 1:36 ` [PATCH 20/24] ath6kl: add target.h Kalle Valo
2011-07-13 1:36 ` [PATCH 21/24] ath6kl: add txrx.c Kalle Valo
2011-07-13 4:31 ` Joe Perches
2011-07-13 8:21 ` Kalle Valo
2011-07-13 8:23 ` Kalle Valo
2011-07-13 1:36 ` [PATCH 22/24] ath6kl: add wmi.c Kalle Valo
2011-07-13 1:36 ` [PATCH 23/24] ath6kl: add wmi.h Kalle Valo
2011-07-13 1:37 ` [PATCH 24/24] ath6kl: add Kconfig and Makefile Kalle Valo
2011-07-13 8:34 ` [PATCH 00/24] ath6kl cleaned up driver Kalle Valo
2011-07-13 9:22 ` Dan Carpenter
2011-07-13 9:28 ` Johannes Berg
2011-07-13 9:34 ` Dan Carpenter
2011-07-13 9:41 ` Johannes Berg
2011-07-13 9:33 ` Dan Carpenter
2011-07-13 10:04 ` Vasanthakumar Thiagarajan
2011-07-14 10:06 ` Dan Carpenter
2011-07-14 10:35 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110713133807.GA3424@vasanth-laptop \
--to=vthiagar@qca.qualcomm.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).