Re: [RFC/RFT 6/6] ath9k: always initialize hw registers related to PCIe PM

[Stanislaw Gruszka <sgruszka@redhat.com>]

On Sat, Jul 23, 2011 at 10:41:30AM +0530, Rajkumar Manoharan wrote:
> > +	/* initalize PCIe PM registers if device introduce itself as PCIe */
> > +	if (ah->is_pciexpress)
> > +		ath9k_hw_ops(ah)->config_pci_powersave(ah, false);
> > +
> Use ath9k_hw_configpcipowersave wrapper instead.
I changed wrapper to check ah->aspm_enabled, so if I would use it here
it will not setup registers. I think I should comment that. 

> And ensure that there is no
> sideeffect by changing SERDES config from __ath9k_hw_init to pci_probe.
Hmm, not sure if I understand what I have to do :-(

We have something like that:

ath_pci_probe
  ath9k_init_device
    ath9k_init_softc
      ath9k_hw_init
	__ath9k_hw_init
            ath9k_hw_configpcipowersave();

I changed it this way:

ath_pci_probe
  ath9k_init_device
    ath9k_init_softc
      ath9k_hw_init
	__ath9k_hw_init

      ath9k_init_queues
      ath9k_init_btcoex
   some other inits
     
  ath9k_hw_configpcipowersave();

Can this cause some side effects?