From: Dan Carpenter <error27@gmail.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: gregkh@suse.de, devel@linuxdriverproject.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 09/29] staging: brcm80211: remove code for unsupported chip
Date: Tue, 26 Jul 2011 11:12:49 +0300 [thread overview]
Message-ID: <20110726081248.GB3824@shale.localdomain> (raw)
In-Reply-To: <1311361036-3175-10-git-send-email-arend@broadcom.com>
On Fri, Jul 22, 2011 at 08:56:56PM +0200, Arend van Spriel wrote:
> From: Franky Lin <frankyl@broadcom.com>
>
> Currently fullmac only support bcm4329. Remove dead code for
> unsupported chip.
This description doesn't match the code at all.
Sorry that I'm looking at this so long after you sent it...
regards,
dan carpenter
>
> Cc: devel@linuxdriverproject.org
> Cc: linux-wireless@vger.kernel.org
> Reported-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Arend van Spriel <arend@broadcom.com>
> ---
> drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c b/drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c
> index 16ea6e8..2a9efc3 100644
> --- a/drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c
> +++ b/drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c
> @@ -980,6 +980,8 @@ static int brcmf_ops_sdio_probe(struct sdio_func *func,
> return -ENOMEM;
> sdiodev->func1 = func;
> dev_set_drvdata(&func->card->dev, sdiodev);
> +
> + atomic_set(&brcmf_mmc_suspend, false);
> }
>
> gInstance->func[func->num] = func;
> --
> 1.7.4.1
>
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
next prev parent reply other threads:[~2011-07-26 8:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 18:56 [PATCH 00/29] staging: brcm80211: cleanup checkpatch warnings Arend van Spriel
2011-07-22 18:56 ` [PATCH 01/29] staging: brcm80211: fixed checkpatch warnings for fullmac Arend van Spriel
2011-07-22 18:56 ` [PATCH 02/29] staging: brcm80211: fixed checkpatch warnings for brcmutil dir Arend van Spriel
2011-07-22 18:56 ` [PATCH 03/29] staging: brcm80211: fixed checkpatch warnings for 'include' dir Arend van Spriel
2011-07-22 18:56 ` [PATCH 04/29] staging: brcm80211: use PCI_DEVICE() macro in device table Arend van Spriel
2011-07-22 18:56 ` [PATCH 05/29] staging: brcm80211: remove unused rx status definitions Arend van Spriel
2011-07-22 18:56 ` [PATCH 06/29] staging: brcm80211: reformat long lines in brcmsmac to 80 columns Arend van Spriel
2011-07-22 18:56 ` [PATCH 07/29] staging: brcm80211: remove wl_alloc_dma_resources() function Arend van Spriel
2011-07-22 18:56 ` [PATCH 09/29] staging: brcm80211: remove code for unsupported chip Arend van Spriel
2011-07-26 8:12 ` Dan Carpenter [this message]
2011-07-22 18:56 ` [PATCH 10/29] staging: brcm80211: cleaned up softmac DMA layer Arend van Spriel
2011-07-22 18:56 ` [PATCH 11/29] staging: brcm80211: removed void * from softmac phy Arend van Spriel
2011-07-22 18:56 ` [PATCH 12/29] staging: brcm80211: simplified register access macro's in softmac Arend van Spriel
2011-07-22 18:57 ` [PATCH 13/29] staging: brcm80211: revisited END_FOREACH_BSS macro Arend van Spriel
2011-07-26 8:26 ` Dan Carpenter
2011-07-26 16:34 ` Joe Perches
2011-07-22 18:57 ` [PATCH 14/29] staging: brcm80211: placed suspend flag in gInstance in brcmfmac Arend van Spriel
2011-07-22 18:57 ` [PATCH 15/29] staging: brcm80211: remove struct brcmf_sdioh_driver from brcmfmac Arend van Spriel
2011-07-22 18:57 ` [PATCH 16/29] staging: brcm80211: remove vendor and device id check " Arend van Spriel
2011-07-22 18:57 ` [PATCH 17/29] staging: brcm80211: remove struct brcmf_sdio_card " Arend van Spriel
2011-07-22 18:57 ` [PATCH 18/29] staging: brcm80211: remove dead code " Arend van Spriel
2011-07-22 18:57 ` [PATCH 19/29] staging: brcm80211: remove dead client interrupt " Arend van Spriel
2011-07-22 18:57 ` [PATCH 20/29] staging: brcm80211: remove function pointer of interrupt isr in brcmfmac Arend van Spriel
2011-07-22 18:57 ` [PATCH 21/29] staging: brcm80211: cleanup to get rid of 'over 80 character' line Arend van Spriel
2011-07-22 18:57 ` [PATCH 22/29] staging: brcm80211: removed unused bus code from softmac Arend van Spriel
2011-07-22 18:57 ` [PATCH 23/29] staging: brcm80211: replaced void *btparam into struct pci_dev *btparam Arend van Spriel
2011-07-22 18:57 ` [PATCH 24/29] staging: brcm80211: removed void * from ai_ functions Arend van Spriel
2011-07-22 18:57 ` [PATCH 25/29] staging: brcm80211: removed brcms_c_module_unregister() call in ampdu.c Arend van Spriel
2011-07-22 18:57 ` [PATCH 26/29] staging: brcm80211: removed watchdog function from softmac Arend van Spriel
2011-07-22 18:57 ` [PATCH 27/29] staging: brcm80211: SPARC build error fix Arend van Spriel
2011-07-22 18:57 ` [PATCH 28/29] staging: brcm80211: remove target platform limitations for drivers Arend van Spriel
2011-07-22 18:57 ` [PATCH 29/29] staging: brcm80211: updated TODO file Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110726081248.GB3824@shale.localdomain \
--to=error27@gmail.com \
--cc=arend@broadcom.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox