From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
ath9k-devel@venema.h4ckr.net, camilo@mesias.co.uk,
Jonathan Nieder <jrnieder@gmail.com>,
Tony Houghton <h@realh.co.uk>,
Rajkumar Manoharan <rmanoharan@atheros.com>,
Adrian Chadd <adrian@freebsd.org>,
linux-pci@vger.kernel.org,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
e1000-devel@lists.sourceforge.net
Subject: Re: [RFC/RFT v2 00/12] ath9k: ASPM fixes
Date: Wed, 27 Jul 2011 09:11:50 -0700 [thread overview]
Message-ID: <20110727091150.4e517f30@jbarnes-desktop> (raw)
In-Reply-To: <1311768899-4559-1-git-send-email-sgruszka@redhat.com>
On Wed, 27 Jul 2011 14:14:47 +0200
Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> This patch series try to fix ath9k ASPM. Some of patches are cleanup
> only or do merging common code (with e1000e driver).
>
> With CONFIG_PCIEASPM it's possible to change ASPM settings on runtime
> via /sys/module/pcie_aspm/parameters/policy . However most drivers
> I looked at assume this setting is constant. I add a callback to pci
> driver to inform about the change, and allow driver to do needed hw
> related changes. Currently only ath9k implement the callback, but
> I think it will be useful for other drivers (i.e. iwlwifi, rtlwifi)
> that do some own ASPM handling.
>
> These patches needs wide testing as they may work on some systems
> and not work on others, that can depend on PCIe bridges.
These look fine, I remember seeing a place where e1000e could use this
just recently and it looks like you took care of it.
We may be able to sneak this in to 3.1 to make things easier on the
dependent drivers, but it'll have to wait until I send my pull request
for the first batch of PCI changes (probably today).
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2011-07-27 16:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 12:14 [RFC/RFT v2 00/12] ath9k: ASPM fixes Stanislaw Gruszka
2011-07-27 12:14 ` [RFC/RFT v2 01/12] ath9k: skip ->config_pci_powersave() if PCIe port has ASPM disabled Stanislaw Gruszka
2011-07-27 12:14 ` [RFC/RFT v2 02/12] ath9k: remove ->config_pci_powersave() redundant argument Stanislaw Gruszka
2011-07-27 12:14 ` [RFC/RFT v2 03/12] ath9k: merge common ->config_pci_powersave() checks Stanislaw Gruszka
2011-07-27 12:14 ` [RFC/RFT v2 04/12] ath9k: use common PCIe ASPM definces instead of custom ones Stanislaw Gruszka
2011-07-27 12:14 ` [RFC/RFT v2 05/12] ath9k: do btcoex ASPM disabling at initialization time Stanislaw Gruszka
2011-07-27 12:14 ` [RFC/RFT v2 06/12] ath9k: init PCIe PM and SERDES registers if ASPM is enabled Stanislaw Gruszka
2011-07-27 12:14 ` [RFC/RFT v2 07/12] pci: aspm: add function for disabling ASPM Stanislaw Gruszka
2011-07-27 12:14 ` [RFC/RFT v2 08/12] ath9k: use common " Stanislaw Gruszka
2011-07-27 12:14 ` [RFC/RFT v2 09/12] e1000e: " Stanislaw Gruszka
2011-07-27 12:14 ` [RFC/RFT v2 10/12] pci: aspm: add settings changed callback Stanislaw Gruszka
2011-07-27 12:14 ` [RFC/RFT v2 11/12] ath9k: be prepare for dynamic ASPM settings change Stanislaw Gruszka
2011-07-27 12:14 ` [RFC/RFT v2 12/12] ath9k: fix initialization ordering issues Stanislaw Gruszka
2011-07-27 16:11 ` Jesse Barnes [this message]
2011-07-29 13:20 ` [RFC/RFT v2 00/12] ath9k: ASPM fixes Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110727091150.4e517f30@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=adrian@freebsd.org \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=camilo@mesias.co.uk \
--cc=e1000-devel@lists.sourceforge.net \
--cc=h@realh.co.uk \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jrnieder@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanoharan@atheros.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).