From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] mac80211: fix resuming when device is gone
Date: Tue, 9 Aug 2011 13:36:21 +0200 [thread overview]
Message-ID: <20110809113620.GA2488@redhat.com> (raw)
In-Reply-To: <1312883113.4109.5.camel@jlt3.sipsolutions.net>
On Tue, Aug 09, 2011 at 11:45:13AM +0200, Johannes Berg wrote:
> > > > Then if ieee80211_reconfig() is called, we schedule
> > > > sta_cleanup timer. After that, when sysfs drop reference counter we
> > > > free rdev. Then sta_info_cleanup() crash kernel.
> > >
> > > Ok let me get this straight -- even after device_del() we get a resume
> > > callback from the core subsystem? That doesn't seem right.
> >
> > No, ieee80211_reconfig() is called before device_del() (but can be
> > called right after ieee80211_unregister_hw() and perhaps
> > ieee80211_free_hw).
>
> Ah so it's racy.
>
> But I think you meant to say resume() is called before device_del()?
Yes, but __ieee80211_resume() calls directly ieee80211_reconfig().
Stanislaw
next prev parent reply other threads:[~2011-08-09 11:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 14:19 [RFC] mac80211: fix resuming when device is gone Stanislaw Gruszka
2011-08-08 15:58 ` Johannes Berg
2011-08-09 9:23 ` Stanislaw Gruszka
2011-08-09 9:28 ` Johannes Berg
2011-08-09 9:29 ` Johannes Berg
2011-08-09 9:43 ` Stanislaw Gruszka
2011-08-09 9:39 ` Stanislaw Gruszka
2011-08-09 9:45 ` Johannes Berg
2011-08-09 11:36 ` Stanislaw Gruszka [this message]
2011-08-09 11:43 ` Johannes Berg
2011-08-09 11:45 ` Johannes Berg
2011-08-09 11:46 ` Johannes Berg
2011-08-09 11:47 ` Johannes Berg
2011-08-09 15:30 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110809113620.GA2488@redhat.com \
--to=sgruszka@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).