From: "John W. Linville" <linville@tuxdriver.com>
To: Senthil Balasubramanian <senthilb@qca.qualcomm.com>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
linux-wireless@vger.kernel.org, Paul Stewart <pstew@google.com>
Subject: Re: [PATCH] ath9k_hw: Fix STA (AR9485) bringup issue due to incorrect MAC address
Date: Fri, 12 Aug 2011 13:17:34 -0400 [thread overview]
Message-ID: <20110812171734.GD2286@tuxdriver.com> (raw)
In-Reply-To: <20110809184415.GB10104@senthil-lnx.users.atheros.com>
On Wed, Aug 10, 2011 at 12:14:16AM +0530, Senthil Balasubramanian wrote:
> On Tue, Aug 09, 2011 at 11:32:17AM -0700, Luis R. Rodriguez wrote:
> > On Tue, Aug 9, 2011 at 11:31 AM, Luis R. Rodriguez <mcgrof@gmail.com> wrote:
> > > On Tue, Aug 9, 2011 at 11:22 AM, Senthil Balasubramanian
> > > <senthilb@qca.qualcomm.com> wrote:
> > >> Due to some recent optimization done in the way the mac address
> > >> bytes are written into the OTP memory, some AR9485 chipsets were
> > >> forced to use the first byte from the eeprom template and as AR9485
> > >> happens to use generic eeprom template which has 0x1 as the first
> > >> byte causes issues in bringing up the card.
> > >>
> > >> So fixed the eeprom template accordingly to address the issue.
> > >>
> > >> Cc: Paul Stewart <pstew@google.com>
> > >> Signed-off-by: Senthil Balasubramanian <senthilb@qca.qualcomm.com>
> > >
> > > I don't follow the description too well, all I can tell from it is
> > > that there is an issue if the template has 0x01 set instead of 0x0 but
> > > it doesn't tell me why.
> The leading byte is 1 which is obviously incorrect for mac address.
> The reason why 1 is chosen by the driver for mac address is due to
> the way the OTP write was optimized and so the driver has taken the
> first byte alone from the template and the remaining from OTP.
>
> >
> > Is this not a stable fix?
> Oops.. Yes it is. Let me cc to stable. thanks for the stable reminder :-(
Are you goint to resubmit a patch w/ a better changelog and
Cc: stable@kernel.org?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-08-12 17:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 18:22 [PATCH] ath9k_hw: Fix STA (AR9485) bringup issue due to incorrect MAC address Senthil Balasubramanian
2011-08-09 18:31 ` Luis R. Rodriguez
2011-08-09 18:32 ` Luis R. Rodriguez
2011-08-09 18:44 ` Senthil Balasubramanian
2011-08-12 17:17 ` John W. Linville [this message]
2011-08-17 7:06 ` Senthil Balasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110812171734.GD2286@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=pstew@google.com \
--cc=senthilb@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).