* [PATCH] ath9k_hw: Fix STA (AR9485) bringup issue due to incorrect MAC address
@ 2011-08-09 18:22 Senthil Balasubramanian
2011-08-09 18:31 ` Luis R. Rodriguez
0 siblings, 1 reply; 6+ messages in thread
From: Senthil Balasubramanian @ 2011-08-09 18:22 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Senthil Balasubramanian, Paul Stewart
Due to some recent optimization done in the way the mac address
bytes are written into the OTP memory, some AR9485 chipsets were
forced to use the first byte from the eeprom template and as AR9485
happens to use generic eeprom template which has 0x1 as the first
byte causes issues in bringing up the card.
So fixed the eeprom template accordingly to address the issue.
Cc: Paul Stewart <pstew@google.com>
Signed-off-by: Senthil Balasubramanian <senthilb@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
index 184abb6..b527ea1 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
@@ -69,7 +69,7 @@ static int ar9003_hw_power_interpolate(int32_t x,
static const struct ar9300_eeprom ar9300_default = {
.eepromVersion = 2,
.templateVersion = 2,
- .macAddr = {1, 2, 3, 4, 5, 6},
+ .macAddr = {0, 2, 3, 4, 5, 6},
.custData = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
.baseEepHeader = {
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ath9k_hw: Fix STA (AR9485) bringup issue due to incorrect MAC address
2011-08-09 18:22 [PATCH] ath9k_hw: Fix STA (AR9485) bringup issue due to incorrect MAC address Senthil Balasubramanian
@ 2011-08-09 18:31 ` Luis R. Rodriguez
2011-08-09 18:32 ` Luis R. Rodriguez
0 siblings, 1 reply; 6+ messages in thread
From: Luis R. Rodriguez @ 2011-08-09 18:31 UTC (permalink / raw)
To: Senthil Balasubramanian; +Cc: linville, linux-wireless, Paul Stewart
On Tue, Aug 9, 2011 at 11:22 AM, Senthil Balasubramanian
<senthilb@qca.qualcomm.com> wrote:
> Due to some recent optimization done in the way the mac address
> bytes are written into the OTP memory, some AR9485 chipsets were
> forced to use the first byte from the eeprom template and as AR9485
> happens to use generic eeprom template which has 0x1 as the first
> byte causes issues in bringing up the card.
>
> So fixed the eeprom template accordingly to address the issue.
>
> Cc: Paul Stewart <pstew@google.com>
> Signed-off-by: Senthil Balasubramanian <senthilb@qca.qualcomm.com>
I don't follow the description too well, all I can tell from it is
that there is an issue if the template has 0x01 set instead of 0x0 but
it doesn't tell me why.
Luis
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k_hw: Fix STA (AR9485) bringup issue due to incorrect MAC address
2011-08-09 18:31 ` Luis R. Rodriguez
@ 2011-08-09 18:32 ` Luis R. Rodriguez
2011-08-09 18:44 ` Senthil Balasubramanian
0 siblings, 1 reply; 6+ messages in thread
From: Luis R. Rodriguez @ 2011-08-09 18:32 UTC (permalink / raw)
To: Senthil Balasubramanian; +Cc: linville, linux-wireless, Paul Stewart
On Tue, Aug 9, 2011 at 11:31 AM, Luis R. Rodriguez <mcgrof@gmail.com> wrote:
> On Tue, Aug 9, 2011 at 11:22 AM, Senthil Balasubramanian
> <senthilb@qca.qualcomm.com> wrote:
>> Due to some recent optimization done in the way the mac address
>> bytes are written into the OTP memory, some AR9485 chipsets were
>> forced to use the first byte from the eeprom template and as AR9485
>> happens to use generic eeprom template which has 0x1 as the first
>> byte causes issues in bringing up the card.
>>
>> So fixed the eeprom template accordingly to address the issue.
>>
>> Cc: Paul Stewart <pstew@google.com>
>> Signed-off-by: Senthil Balasubramanian <senthilb@qca.qualcomm.com>
>
> I don't follow the description too well, all I can tell from it is
> that there is an issue if the template has 0x01 set instead of 0x0 but
> it doesn't tell me why.
Is this not a stable fix?
Luis
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k_hw: Fix STA (AR9485) bringup issue due to incorrect MAC address
2011-08-09 18:32 ` Luis R. Rodriguez
@ 2011-08-09 18:44 ` Senthil Balasubramanian
2011-08-12 17:17 ` John W. Linville
0 siblings, 1 reply; 6+ messages in thread
From: Senthil Balasubramanian @ 2011-08-09 18:44 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linville, linux-wireless, Paul Stewart
On Tue, Aug 09, 2011 at 11:32:17AM -0700, Luis R. Rodriguez wrote:
> On Tue, Aug 9, 2011 at 11:31 AM, Luis R. Rodriguez <mcgrof@gmail.com> wrote:
> > On Tue, Aug 9, 2011 at 11:22 AM, Senthil Balasubramanian
> > <senthilb@qca.qualcomm.com> wrote:
> >> Due to some recent optimization done in the way the mac address
> >> bytes are written into the OTP memory, some AR9485 chipsets were
> >> forced to use the first byte from the eeprom template and as AR9485
> >> happens to use generic eeprom template which has 0x1 as the first
> >> byte causes issues in bringing up the card.
> >>
> >> So fixed the eeprom template accordingly to address the issue.
> >>
> >> Cc: Paul Stewart <pstew@google.com>
> >> Signed-off-by: Senthil Balasubramanian <senthilb@qca.qualcomm.com>
> >
> > I don't follow the description too well, all I can tell from it is
> > that there is an issue if the template has 0x01 set instead of 0x0 but
> > it doesn't tell me why.
The leading byte is 1 which is obviously incorrect for mac address.
The reason why 1 is chosen by the driver for mac address is due to
the way the OTP write was optimized and so the driver has taken the
first byte alone from the template and the remaining from OTP.
>
> Is this not a stable fix?
Oops.. Yes it is. Let me cc to stable. thanks for the stable reminder :-(
>
> Luis
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k_hw: Fix STA (AR9485) bringup issue due to incorrect MAC address
2011-08-09 18:44 ` Senthil Balasubramanian
@ 2011-08-12 17:17 ` John W. Linville
2011-08-17 7:06 ` Senthil Balasubramanian
0 siblings, 1 reply; 6+ messages in thread
From: John W. Linville @ 2011-08-12 17:17 UTC (permalink / raw)
To: Senthil Balasubramanian; +Cc: Luis R. Rodriguez, linux-wireless, Paul Stewart
On Wed, Aug 10, 2011 at 12:14:16AM +0530, Senthil Balasubramanian wrote:
> On Tue, Aug 09, 2011 at 11:32:17AM -0700, Luis R. Rodriguez wrote:
> > On Tue, Aug 9, 2011 at 11:31 AM, Luis R. Rodriguez <mcgrof@gmail.com> wrote:
> > > On Tue, Aug 9, 2011 at 11:22 AM, Senthil Balasubramanian
> > > <senthilb@qca.qualcomm.com> wrote:
> > >> Due to some recent optimization done in the way the mac address
> > >> bytes are written into the OTP memory, some AR9485 chipsets were
> > >> forced to use the first byte from the eeprom template and as AR9485
> > >> happens to use generic eeprom template which has 0x1 as the first
> > >> byte causes issues in bringing up the card.
> > >>
> > >> So fixed the eeprom template accordingly to address the issue.
> > >>
> > >> Cc: Paul Stewart <pstew@google.com>
> > >> Signed-off-by: Senthil Balasubramanian <senthilb@qca.qualcomm.com>
> > >
> > > I don't follow the description too well, all I can tell from it is
> > > that there is an issue if the template has 0x01 set instead of 0x0 but
> > > it doesn't tell me why.
> The leading byte is 1 which is obviously incorrect for mac address.
> The reason why 1 is chosen by the driver for mac address is due to
> the way the OTP write was optimized and so the driver has taken the
> first byte alone from the template and the remaining from OTP.
>
> >
> > Is this not a stable fix?
> Oops.. Yes it is. Let me cc to stable. thanks for the stable reminder :-(
Are you goint to resubmit a patch w/ a better changelog and
Cc: stable@kernel.org?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k_hw: Fix STA (AR9485) bringup issue due to incorrect MAC address
2011-08-12 17:17 ` John W. Linville
@ 2011-08-17 7:06 ` Senthil Balasubramanian
0 siblings, 0 replies; 6+ messages in thread
From: Senthil Balasubramanian @ 2011-08-17 7:06 UTC (permalink / raw)
To: John W. Linville; +Cc: Luis R. Rodriguez, linux-wireless, Paul Stewart
On Fri, Aug 12, 2011 at 01:17:34PM -0400, John W. Linville wrote:
> On Wed, Aug 10, 2011 at 12:14:16AM +0530, Senthil Balasubramanian wrote:
> > On Tue, Aug 09, 2011 at 11:32:17AM -0700, Luis R. Rodriguez wrote:
> > > On Tue, Aug 9, 2011 at 11:31 AM, Luis R. Rodriguez <mcgrof@gmail.com> wrote:
> > > > On Tue, Aug 9, 2011 at 11:22 AM, Senthil Balasubramanian
> > > > <senthilb@qca.qualcomm.com> wrote:
> > > >> Due to some recent optimization done in the way the mac address
> > > >> bytes are written into the OTP memory, some AR9485 chipsets were
> > > >> forced to use the first byte from the eeprom template and as AR9485
> > > >> happens to use generic eeprom template which has 0x1 as the first
> > > >> byte causes issues in bringing up the card.
> > > >>
> > > >> So fixed the eeprom template accordingly to address the issue.
> > > >>
> > > >> Cc: Paul Stewart <pstew@google.com>
> > > >> Signed-off-by: Senthil Balasubramanian <senthilb@qca.qualcomm.com>
> > > >
> > > > I don't follow the description too well, all I can tell from it is
> > > > that there is an issue if the template has 0x01 set instead of 0x0 but
> > > > it doesn't tell me why.
> > The leading byte is 1 which is obviously incorrect for mac address.
> > The reason why 1 is chosen by the driver for mac address is due to
> > the way the OTP write was optimized and so the driver has taken the
> > first byte alone from the template and the remaining from OTP.
> >
> > >
> > > Is this not a stable fix?
> > Oops.. Yes it is. Let me cc to stable. thanks for the stable reminder :-(
>
> Are you goint to resubmit a patch w/ a better changelog and
> Cc: stable@kernel.org?
Yes.. John. Sorry! for the long silence from my side.
>
> John
> --
> John W. Linville Someday the world will need a hero, and you
> linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-08-17 7:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-09 18:22 [PATCH] ath9k_hw: Fix STA (AR9485) bringup issue due to incorrect MAC address Senthil Balasubramanian
2011-08-09 18:31 ` Luis R. Rodriguez
2011-08-09 18:32 ` Luis R. Rodriguez
2011-08-09 18:44 ` Senthil Balasubramanian
2011-08-12 17:17 ` John W. Linville
2011-08-17 7:06 ` Senthil Balasubramanian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).