From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
lrodriguez@atheros.com
Subject: Re: [PATCH] ath9k: remove a bogus WARN_ON
Date: Mon, 15 Aug 2011 12:51:48 +0200 [thread overview]
Message-ID: <20110815105146.GA15300@redhat.com> (raw)
In-Reply-To: <1313252029-17665-1-git-send-email-nbd@openwrt.org>
On Sat, Aug 13, 2011 at 10:13:49AM -0600, Felix Fietkau wrote:
> On embedded hardware it's normal to not have a PCI device for the PCI
> bridge that the wifi card is attached to. pdev->bus->self will be
> NULL in that case. In that case, simply return without emitting an
> useless kernel stack trace.
Patch is obviously ok, ACK. However I'm not sure if we should not
do anything regarding ASPM. Perhaps there is other way to find out
pcie parent ASPM settings on embedded systems?
Stanislaw
next prev parent reply other threads:[~2011-08-15 10:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-13 16:13 [PATCH] ath9k: remove a bogus WARN_ON Felix Fietkau
2011-08-15 10:51 ` Stanislaw Gruszka [this message]
2011-08-20 13:43 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110815105146.GA15300@redhat.com \
--to=sgruszka@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).