Re: [RFT v2 2/2] ath9k: add AR9580 support

[Florian Fainelli <florian@openwrt.org>]

On Tuesday 23 August 2011 15:16:32 Luis R. Rodriguez wrote:
> On Tue, Aug 23, 2011 at 1:09 AM, Florian Fainelli <florian@openwrt.org> 
wrote:
> > On Tuesday 23 August 2011 10:07:44 Florian Fainelli wrote:
> >> Hello Luis,
> >> 
> >> On Tuesday 23 August 2011 02:08:39 Luis R. Rodriguez wrote:
> >> > From: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
> >> > 
> >> > Signed-off-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
> >> > ---
> >> > 
> >> >  drivers/net/wireless/ath/ath9k/pci.c |    1 +
> >> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >> > 
> >> > diff --git a/drivers/net/wireless/ath/ath9k/pci.c
> >> > b/drivers/net/wireless/ath/ath9k/pci.c index daa26b5..6cb90ee 100644
> >> > --- a/drivers/net/wireless/ath/ath9k/pci.c
> >> > +++ b/drivers/net/wireless/ath/ath9k/pci.c
> >> > @@ -32,6 +32,7 @@ static DEFINE_PCI_DEVICE_TABLE(ath_pci_id_table) = {
> >> > 
> >> >     { PCI_VDEVICE(ATHEROS, 0x002E) }, /* PCI-E */
> >> >     { PCI_VDEVICE(ATHEROS, 0x0030) }, /* PCI-E  AR9300 */
> >> >     { PCI_VDEVICE(ATHEROS, 0x0032) }, /* PCI-E  AR9485 */
> >> > 
> >> > +   { PCI_VDEVICE(ATHEROS, 0x0033) }, /* PCI-E  AR9580 */
> >> > 
> >> >     { 0 }
> >> > 
> >> >  };
> >> 
> >> You also need this change in hw.{c,h} for ath9k not to bail out with
> >> "ath: Hardware device ID 0x0033 not supported":
> >> 
> >> Index: compat-wireless-2011-08-10/drivers/net/wireless/ath/ath9k/hw.c
> >> ===================================================================
> >> --- compat-wireless-2011-08-10.orig/drivers/net/wireless/ath/ath9k/hw.c
> >> 2011-08-23 10:01:30.804054398 +0200
> >> +++ compat-wireless-2011-08-10/drivers/net/wireless/ath/ath9k/hw.c
> >> 2011-08-23 10:01:46.314054408 +0200
> >> @@ -672,6 +672,7 @@
> >>         case AR9300_DEVID_AR9485_PCIE:
> >>         case AR9300_DEVID_AR9330:
> >>         case AR9300_DEVID_AR9340:
> >> +       case AR9300_DEVID_AR9580:
> >>                 break;
> >>         default:
> >>                 if (common->bus_ops->ath_bus_type == ATH_USB)
> >> Index: compat-wireless-2011-08-10/drivers/net/wireless/ath/ath9k/hw.h
> >> ===================================================================
> >> --- compat-wireless-2011-08-10.orig/drivers/net/wireless/ath/ath9k/hw.h
> >> 2011-08-23 10:01:32.504054400 +0200
> >> +++ compat-wireless-2011-08-10/drivers/net/wireless/ath/ath9k/hw.h
> >> 2011-08-23 10:01:59.124054416 +0200
> >> @@ -45,6 +45,7 @@
> >>  #define AR9300_DEVID_PCIE      0x0030
> >>  #define AR9300_DEVID_AR9340    0x0031
> >>  #define AR9300_DEVID_AR9485_PCIE 0x0032
> >> +#define AR9300_DEVID_AR9580    0x0033
> >>  #define AR9300_DEVID_AR9330    0x0035
> >> 
> >>  #define AR5416_AR9100_DEVID    0x000b
> >> 
> >> With the above two patches applied, I get the following:
> >> 
> >> iw dev wlan0 scan
> >> command failed: Device or resource busy (-16)
> > 
> > I had wpa_supplicant running in background, scan does no longer report
> > Device or resource busy now.
> 
> You do get scan results now?

Yes I do, I was confused with the regulatory domain configured, plus there is 
not that many 5Ghz activity around me.

> 
> >> iw phy0 info shows the 5GHz band has being listed
> >> 
> >> iw dev wlan0 survey dump seems to correctly list the activity on the
> >> 5Ghz channels (it's updated from one call to another)
> >> 
> >> if I start the interface in AP mode, my laptop does not see it's beacon,
> >> I have not had a chance yet to use a monitor interface.
> > 
> > I will test later the opposite, where my laptop is in AP mode, and try to
> > get this AR9580 device in STA mode.
> 
> OK thanks.

This is working fine in both modes: AP and STA, and I get pretty decent rates 
(~56,2 Mbits/sec unencrypted) in both directions and roles.

Feel free to add my Tested-by: Florian Fainelli <florian@openwrt.org> to the 
final patchset.

Thank you very much for your support on this!
-- 
Florian