From: Ali Bahar <ali@internetdog.org>
To: Greg KH <greg@kroah.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] staging: r8712u: Most return-values changed from -1 to proper errno macros.
Date: Wed, 24 Aug 2011 09:42:57 +0800 [thread overview]
Message-ID: <20110824014257.GB20603@internetdog.org> (raw)
In-Reply-To: <20110823195239.GA17945@kroah.com>
On Tue, Aug 23, 2011 at 12:52:39PM -0700, Greg KH wrote:
> On Sat, Jul 16, 2011 at 02:59:33PM +0800, Ali Bahar wrote:
> > The ioctl handlers were frequently returning -1 upon failure. Most of
> > these have now been changed to proper errno macros.
> > The few remaining ones have been left untouched because either the
> > handler is not called (and so cannot be tested), or the function never
> > fails (and so cannot be system-tested), or requires new code to
> > distinguish its failures.
> >
> > Signed-off-by: Ali Bahar <ali@internetDog.org>
> > Cc: Larry Finger <Larry.Finger@lwfinger.net>
>
> This fails to apply cleanly anymore, can you refresh it, and your other
> outstanding patches and resend?
At this point, it is best to send this _on top of_ the Realtek-merge
patches, even though the latter are more prone to revisions.
So the new patch set will include the merge changes, and the above
("return-values") changes, with the latter to be applied _on top of_
the former. I'll put a reminder of this in the submission email.
regards,
ali
> thanks,
>
> greg k-h
prev parent reply other threads:[~2011-08-24 1:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-16 6:59 [PATCH v2] staging: r8712u: Most return-values changed from -1 to proper errno macros Ali Bahar
2011-08-23 19:52 ` Greg KH
2011-08-24 1:42 ` Ali Bahar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110824014257.GB20603@internetdog.org \
--to=ali@internetdog.org \
--cc=Larry.Finger@lwfinger.net \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).