From: "Michael Büsch" <m@bues.ch>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: zajec5@gmail.com, Michael Buesch <mb@bu3sch.de>,
b43-dev@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [RFC/RFT] b43: Relax requirement for descriptors to be in the DMA zone
Date: Wed, 24 Aug 2011 21:53:09 +0200 [thread overview]
Message-ID: <20110824215309.2f2cbb73@milhouse> (raw)
In-Reply-To: <4e5553a8.vSmpTZc2Cr8jeze3%Larry.Finger@lwfinger.net>
On Wed, 24 Aug 2011 14:40:24 -0500
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> @Rafal - Incorporate this in your other patch.
I would rather like to have this as a separate patch and have
Rafal's other patch apply on _top_ of this.
> @@ -903,7 +896,7 @@ struct b43_dmaring *b43_setup_dmaring(st
> kfree(ring->txhdr_cache);
> ring->txhdr_cache = kcalloc(ring->nr_slots / TX_SLOTS_PER_FRAME,
> b43_txhdr_size(dev),
> - GFP_KERNEL | GFP_DMA);
> + GFP_KERNEL);
> if (!ring->txhdr_cache)
> goto err_kfree_meta;
>
>
Why are you removing this? Seems wrong to me.
This seems to be part of the bounce-buffer mechanism, that we _do_ still need
for legacy 30bit devices.
--
Greetings, Michael.
next prev parent reply other threads:[~2011-08-24 19:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 19:40 [RFC/RFT] b43: Relax requirement for descriptors to be in the DMA zone Larry Finger
2011-08-24 19:53 ` Michael Büsch [this message]
2011-08-24 20:59 ` Rafał Miłecki
-- strict thread matches above, loose matches on Subject: below --
2011-08-24 22:02 Larry Finger
2011-08-24 22:17 ` Michael Büsch
2011-08-25 17:24 ` Rafał Miłecki
2011-08-25 17:29 ` Larry Finger
2011-08-25 18:08 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110824215309.2f2cbb73@milhouse \
--to=m@bues.ch \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).