Linux wireless drivers development
 help / color / mirror / Atom feed
From: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: <linux-wireless@vger.kernel.org>, <linville@tuxdriver.com>,
	<rodrigue@qca.qualcomm.com>,
	Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Subject: Re: [PATCH] ath9k: fix checks for first subframe delimiter padding
Date: Mon, 29 Aug 2011 16:34:28 +0530	[thread overview]
Message-ID: <20110829110427.GA29376@vasanth-laptop> (raw)
In-Reply-To: <1314615061-6354-1-git-send-email-nbd@openwrt.org>

On Mon, Aug 29, 2011 at 12:51:01PM +0200, Felix Fietkau wrote:
> The commit "ath9k_hw: Fix exceed transmission burst-time of 5GHz" added
> a padding of 60 delimiters on the first subframe to work around an issue
> on AR9380, but it lacked the checks to prevent it from being applied to
> pre-AR9380, enterprise AR9380 or AR9580+
> 
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> Cc: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
> ---
>  drivers/net/wireless/ath/ath9k/reg.h  |    1 +
>  drivers/net/wireless/ath/ath9k/xmit.c |    4 +++-
>  2 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/reg.h b/drivers/net/wireless/ath/ath9k/reg.h
> index a3b8bbc..989514a 100644
> --- a/drivers/net/wireless/ath/ath9k/reg.h
> +++ b/drivers/net/wireless/ath/ath9k/reg.h
> @@ -1131,6 +1131,7 @@ enum {
>  #define AR_INTR_PRIO_ASYNC_ENABLE (AR_SREV_9340(ah) ? 0x4094 : 0x40d4)
>  #define AR_ENT_OTP		  0x40d8
>  #define AR_ENT_OTP_CHAIN2_DISABLE               0x00020000
> +#define AR_ENT_OTP_MIN_PKT_SIZE_DISABLE		0x00800000
>  #define AR_ENT_OTP_MPSD		0x00800000

Looks like AR_ENT_OTP_MPSD was defined for this purpose,
unfortunately it so difficult to understand anything from this
macro. Can you also this redundant definition?

Vasanth

  reply	other threads:[~2011-08-29 11:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-29 10:51 [PATCH] ath9k: fix checks for first subframe delimiter padding Felix Fietkau
2011-08-29 11:04 ` Vasanthakumar Thiagarajan [this message]
2011-08-29 11:11   ` Vasanthakumar Thiagarajan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110829110427.GA29376@vasanth-laptop \
    --to=vthiagar@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=nbd@openwrt.org \
    --cc=rmanohar@qca.qualcomm.com \
    --cc=rodrigue@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox