From: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH V3] ath6kl: ath6kl: Add debugfs interface to dump diagnostic registers
Date: Fri, 2 Sep 2011 13:53:04 +0530 [thread overview]
Message-ID: <20110902082303.GD5883@vasanth-laptop> (raw)
In-Reply-To: <4E609204.5080300@qca.qualcomm.com>
On Fri, Sep 02, 2011 at 11:21:24AM +0300, Kalle Valo wrote:
> On 09/02/2011 11:01 AM, Vasanthakumar Thiagarajan wrote:
> > On Fri, Sep 02, 2011 at 10:55:03AM +0300, Kalle Valo wrote:
> >> On 09/01/2011 01:09 PM, Vasanthakumar Thiagarajan wrote:
> >>
> >> Thanks, applied. But I did minor changes:
> >>
> >> commit 91d57de5adfc40184ef7cb8974104459c5211add
> >> Author: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
> >> Date: Fri Sep 2 10:40:06 2011 +0300
> >>
> >> ath6kl: Add debugfs interface to dump diagnostic registers from firmware
> >>
> >> To dump a particular register:
> >>
> >> echo <reg_addr> > <debugfs_root>/ieee80211/phyX/ath6kl/reg_addr
> >>
> >> To dump the entire register set:
> >>
> >> echo 0 > <debugfs_root>/ieee80211/phyX/ath6kl/reg_addr
> >>
> >> Register values will be available at:
> >>
> >> cat <debugfs_root>/ieee80211/phyX/ath6kl/reg_dump
> >>
> >> kvalo: commit log cleanup, renamed few functions, removed a warning
> >> message
> >
> > Thanks, what is the warning?
>
> I just removed the ath6kl_warn() about invalid register address in
> ath6kl_dbg_is_diag_reg_valid(). Kernel should not send any debug logs in
> that case.
Ok, thanks.
>
> > Did you apply my other patch which fixes endianess?.
>
> No, not yet. I still have patches pending for review. Will finish them
> today.
No problem, i thought it was a sparse warning.
Vasanth
next prev parent reply other threads:[~2011-09-02 8:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 10:09 [PATCH V3] ath6kl: ath6kl: Add debugfs interface to dump diagnostic registers Vasanthakumar Thiagarajan
2011-09-02 7:55 ` Kalle Valo
2011-09-02 8:01 ` Vasanthakumar Thiagarajan
2011-09-02 8:21 ` Kalle Valo
2011-09-02 8:23 ` Vasanthakumar Thiagarajan [this message]
2011-09-02 8:21 ` Vasanthakumar Thiagarajan
2011-09-02 8:23 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110902082303.GD5883@vasanth-laptop \
--to=vthiagar@qca.qualcomm.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).