From: Marek Lindner <lindner_marek@yahoo.de>
To: Alexander Simon <an.alexsimon@googlemail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 4/4] mac80211: Add HT operation modes for IBSS
Date: Fri, 9 Sep 2011 16:17:20 +0200 [thread overview]
Message-ID: <201109091617.21038.lindner_marek@yahoo.de> (raw)
In-Reply-To: <2070049.m7Ejz2Cj4P@alex-1>
On Monday, August 29, 2011 16:32:12 you wrote:
> @@ -380,7 +382,8 @@ int ieee80211_start_tx_ba_session(struct ieee80211_sta
> *pubsta, u16 tid,
> */
> if (sdata->vif.type != NL80211_IFTYPE_STATION &&
> sdata->vif.type != NL80211_IFTYPE_AP_VLAN &&
> - sdata->vif.type != NL80211_IFTYPE_AP)
> + sdata->vif.type != NL80211_IFTYPE_AP &&
> + sdata->vif.type != NL80211_IFTYPE_ADHOC)
> return -EINVAL;
You should update the comment regarding IBSS mode direct above this check too.
> + /* update HT IE. If not yet existing, create one */
> + nskb = skb_copy(skb, GFP_ATOMIC);
> + ht_ie = (u8 *)cfg80211_find_ie(WLAN_EID_HT_CAPABILITY,
> + (const u8 *)(nskb->data + 24 +
> + sizeof(mgmt->u.beacon)),
> + nskb->len - 24 -
> + sizeof(mgmt->u.beacon));
> + if (!ht_ie)
> + ht_ie = skb_put(nskb, 4 +
> + sizeof(struct ieee80211_ht_cap) +
> + sizeof(struct ieee80211_ht_info));
AFAIK, you can not safely assume that you have enough room left for skb_put().
You might trigger a skb_over_panic().
> @@ -2160,7 +2160,8 @@ ieee80211_rx_h_action(struct ieee80211_rx_data *rx)
> */
> if (sdata->vif.type != NL80211_IFTYPE_STATION &&
> sdata->vif.type != NL80211_IFTYPE_AP_VLAN &&
> - sdata->vif.type != NL80211_IFTYPE_AP)
> + sdata->vif.type != NL80211_IFTYPE_AP &&
> + sdata->vif.type != NL80211_IFTYPE_ADHOC)
> break;
Also requires a "comment update".
Cheers,
Marek
next prev parent reply other threads:[~2011-09-09 14:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 14:15 [PATCH v2 1/4] nl80211: Parse channel type attribute in an IBSS join request Alexander Simon
2011-08-29 14:30 ` [PATCH v2 2/4] cfg80211: Add cfg80211_get_bss_ht to also match HT configuration Alexander Simon
2011-08-31 6:37 ` Johannes Berg
2011-09-09 14:07 ` Marek Lindner
2011-08-29 14:31 ` [PATCH v2 3/4] mac80211: Add HT helper functions Alexander Simon
2011-08-31 6:38 ` Johannes Berg
2011-08-29 14:32 ` [PATCH v2 4/4] mac80211: Add HT operation modes for IBSS Alexander Simon
2011-09-09 14:17 ` Marek Lindner [this message]
2011-08-31 6:36 ` [PATCH v2 1/4] nl80211: Parse channel type attribute in an IBSS join request Johannes Berg
2011-08-31 13:49 ` Alexander Simon
2011-09-01 13:18 ` Johannes Berg
2011-08-31 15:51 ` Marek Lindner
2011-08-31 16:44 ` Alexander Simon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109091617.21038.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=an.alexsimon@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).